Repository navigation
Conversation
A list row's leading image always fills its 56pt square, cropping whatever doesn't fit. leadingImageFit="contain" letterboxes instead, for artwork whose aspect ratio carries the meaning (a wide illustration, a logo). The default stays cover, so existing thumbnails are untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's wrong
A list item's leading image always fills its square and crops whatever doesn't fit. That's fine for photos, but a wide picture or a logo loses its edges.
What this does
A new opt-in
leadingImageFit="contain"shows the whole image inside the square instead of cropping it. The default stays as it is today (fill and crop), so existing lists don't change. It reuses the image loading from #56 and only passes the fit along. iOS and Android.How to reproduce
The same wide image twice.