Repository navigation
Conversation
With glass, a selected chip painted its on-primary label over an untinted glass plate: light text on light glass. The selected state now tints the glass with the fill colour (iOS 26), or fills the capsule on older versions, so the label keeps its contrast.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
class="glass"(orglass:interactive) on anative:chip, the selected chip can't be read on iOS 26. Its label uses the theme's on-primary colour, which is meant for the primary fill, but with glass there is no fill: light text on a light glass plate.Fix: a selected glass chip tints its glass with the fill colour (
Glass.tint), the way Apple's own apps show a selected glass filter. On iOS versions before 26 the material fallback fills the capsule instead. Unselected chips and chips without glass are unchanged.To reproduce:
Before / after (iPhone 17 Pro Max simulator, iOS 26.5): "All" is invisible before, and tinted and readable after: