Repository navigation
Conversation
…scheme Lists, dividers and outlined controls draw with MaterialTheme's outlineVariant, which kept Material's baseline lilac grey whatever the app configured.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Android, list separators ignore the theme's
outline-variantcolour.#15 added
outline-variantas "the softer neutral for hairline dividers and card seams". The Android theme store reads it from the config, buttoMaterialColorScheme()never copies it into the Material colour scheme, unlike its neighbours (outline,surfaceVariant, …). Everything that draws withMaterialTheme.colorScheme.outlineVarianttherefore keeps Material's baseline colour, whatever the app sets:native:list separator, plain and grouped;HorizontalDividerwith no colour, outlined cards, the tab row's bottom line).That baseline is a lilac grey (
#CAC4D0) in light mode and a dark purple-grey (#49454F) in dark mode. The dark one looks heavy on light cards, and neither matches the app's palette. iOS isn't affected: its lists use the system separator.This PR adds the missing line:
Separators now use the configured colour in both modes. An app that never set
outline-variantgets the package default (#E2E8F0light,#334155dark), which is the same default iOS already uses. Nothing else changes.This complements #94, which fixes the standalone
native:dividerelement (it reads the theme store directly, not the Material scheme).To reproduce, set an obvious colour in
config/native-ui.php:Before / after on a Xiaomi phone (Android 16), light and dark mode. Measured separator pixels: before
#CAC4D0/#49454F, after#E53935in both modes: