Repository navigation
docs: mark environment variable runtime scopes - #138
Merged
NekomyaDev merged 2 commits intoOct 16, 2026
Merged
Conversation
NekomyaDev
requested changes
Oct 16, 2026
NekomyaDev
left a comment
Owner
There was a problem hiding this comment.
Thank you for working on this! Several scope annotations in the Environment Variables table need corrections before merging:
NUDGE_REPAIR_BUDGET: Marked aspython/TS, but it is only read in the Python runtime (runtime/nudge_runtime/__init__.py:1494) and is absent fromruntime/nudge_runtime.ts. This should bepython.NUDGE_OTELandNUDGE_OTEL_ENDPOINT: Marked aspython/TS, but they are only implemented in Python (runtime/nudge_runtime/__init__.py:727, 749) and not in TypeScript or native Rust. These should bepython.NUDGE_DECISION_SERVERSandNUDGE_DECISION_CACHE: Marked asboth, but neither is supported in the native Rust runtime (crates/has only deterministic fake decisions; live servers and caching are Python/TS only). Marking them asbothis inaccurate.- CI Status:
pre-commit.ciis currently failing on this branch.
Please update the annotations and rebase/fix CI so we can get this landed.
Contributor
Author
|
Updated the environment variable scope annotations as requested:
Also applied the whitespace and EOF fixes reported by pre-commit.ci. The new pre-commit.ci check is passing on commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #133\n\n## Problem\nThe README environment-variable table did not say whether each variable is read by the native Rust runtime, the legacy Python/TypeScript runtimes, or both.\n\n## Change\nAdded a Scope column for every row, split mixed-scope rows where needed, and documented the scope labels.\n\n## Validation\n- git diff --check