feat: add self-timeout by Uniolo1 · Pull Request #49 · Neon-Genesis-Linux/pen-bot

Uniolo1 · 2026-10-03T23:46:38Z

This PR adds a self-timeout feature, fixing #26. Thanks to @dearfenane for helping me with this!

AI Usage disclosure

Stack overflow was down while I was working on part of this, so I used it to ask how to check if the duration is between a specific window and how to format a string. I just used ChatGPT.

Tests and stuff

CONTRIBUTING.md says to run a bunch of commands and to copy the output, so here it is!

user@the-puter:~/code/pen-bot-uniolo1$ test -z "$(gofmt -l .)"
go mod tidy && git diff --exit-code go.mod go.sum
go vet ./...
go test ./...
./custom-gcl run --timeout=5m ./...
?   	github.com/Neon-Genesis-Linux/pen-bot/cmd/pen-fun	[no test files]
?   	github.com/Neon-Genesis-Linux/pen-bot/internal/community	[no test files]
?   	github.com/Neon-Genesis-Linux/pen-bot/internal/core	[no test files]
ok  	github.com/Neon-Genesis-Linux/pen-bot/internal/db	(cached)
?   	github.com/Neon-Genesis-Linux/pen-bot/internal/logger	[no test files]
?   	github.com/Neon-Genesis-Linux/pen-bot/internal/moderation	[no test files]
bash: ./custom-gcl: No such file or directory
user@the-puter:~/code/pen-bot-uniolo1$

FYI: CONTRIBUTING.md says to Read DOCUMENTATION.md first, but DOCUMENTATION.md does not seem to exist

fixes #26

dearfenane

some typos i noticed

dearfenane · 2026-10-04T00:00:13Z

+	GuildID := e.GuildID()
+	if GuildID == nil {
+		// NOTE: should have been caught earlier
+		embed := selfTimeoutCommandEmbed("Command unavalible!", "This command can only be used in servers!", true)


dearfenane · 2026-10-04T00:00:31Z

+		return updateEmbed(e, embed)
+	}
+
+	embed := selfTimeoutCommandEmbed("Sucessfully timed out", "See you later!", false)


dearfenane · 2026-10-04T00:00:40Z

+	}
+
+	if e.GuildID() == nil {
+		embed = selfTimeoutCommandEmbed("Command unavalible!", "This command can only be used in servers!", true)


dearfenane · 2026-10-04T00:06:36Z

+
+	// confirmation message
+	embed = selfTimeoutCommandEmbed("Confirm timeout", fmt.Sprintf(
+		"You are about to time yourself out, **this action is irreversal**, "+


shouldve been irreversible, not irreversal

shouldve been irreversible, not irreversal

Fixed typos you noticed (x2)

Uniolo1 · 2026-10-04T00:06:47Z

some typos i noticed

Fixed the typos you noticed.

dearfenane

also it seems like github didnt recognize the fixing thing, maybe do it "fixes #26" at the bottom of the pr

dearfenane · 2026-10-04T00:29:59Z

also i have just noticed

./custom-gcl run --timeout=5m ./...
?   	github.com/Neon-Genesis-Linux/pen-bot/cmd/pen-fun	[no test files]
?   	github.com/Neon-Genesis-Linux/pen-bot/internal/community	[no test files]
?   	github.com/Neon-Genesis-Linux/pen-bot/internal/core	[no test files]
ok  	github.com/Neon-Genesis-Linux/pen-bot/internal/db	(cached)
?   	github.com/Neon-Genesis-Linux/pen-bot/internal/logger	[no test files]
?   	github.com/Neon-Genesis-Linux/pen-bot/internal/moderation	[no test files]
bash: ./custom-gcl: No such file or directory
user@the-puter:~/code/pen-bot-uniolo1$

you need to run golangci-lint custom first...

Uniolo1 · 2026-10-04T00:40:16Z

Amended commit (again) to fix issues noted.

dearfenane

change this and ill approve your pr (though you will need your pr reviewed by vuks as well)

dearfenane

LGTM

Uniolo1 · 2026-10-04T02:17:24Z

Converting to draft: realized it should be in pen-mod not pen-fun, will amend after I figure out how I should go about dealing with docker and the README (since that would require adding a new binary)

Vuks69

Overall pretty well executed, just some inconsistencies.

Vuks69 · 2026-10-04T09:24:37Z

+	if err != nil {
+		embed := selfTimeoutCommandEmbed("Invalid permissions!", fmt.Sprintf("The bot lacks permission to timeout <@%s>", e.Member().User.ID), true)
+		return updateEmbed(e, embed)
+	}


The error is discarded and misdiagnosed. Every UpdateMember failure renders as "Invalid permissions!". A 404 unknown-member, a 429, a 5xx, or a network blip all tell the user to check their permissions.

And because you return updateEmbed's error rather than the REST error, disgo's default error handler logs only the edit failure; the timeout failure itself leaves no trace. Use rest.IsJSONErrorCode(err, rest.JSONErrorCodeMissingAccess) / errors.As for the 403 branch and slog.Error the rest, the way tldr does.

Vuks69 · 2026-10-04T09:25:20Z

+
+	// buttons for embed
+	var buttons = [2]discord.ButtonComponent{
+		discord.NewDangerButton("I understand", fmt.Sprintf("/"+selfTimeoutCommand+"/Confirm/%s", duration.String())),


AI raised a potential problem with no expiry, so someone could click the button a few days later and still get timed out. Not sure how much of a problem this really would be. Can be fixed by including an expiry timestamp in the ID and checking it on click.

Not sure how much of a problem this really would be

I don't think it is that big of an issue. The message is ephemeral so it will go away after some time

Vuks69 · 2026-10-04T09:33:27Z

+	duration, err := time.ParseDuration(durationString)
+	if err != nil {
+		embed = selfTimeoutCommandEmbed("Invalid duration", fmt.Sprintf("'%s' is not a valid duration!", durationString), true)
+		return sendEmbed(e, embed, nil)
+	}
+
+	// Ensure ms/ns times are not accepted
+	duration = duration.Round(time.Second)
+
+	// ensure duration is not too long or too short
+	// NOTE: "duration.String()" is more verbose as it includes values not specified by the user (as '0')
+	if duration < 10*time.Second {
+		embed = selfTimeoutCommandEmbed("Invalid duration", fmt.Sprintf("`%s` is too short", durationString), true)
+		return sendEmbed(e, embed, nil)
+	} else if duration > 3*24*time.Hour {
+		embed = selfTimeoutCommandEmbed("Invalid duration", fmt.Sprintf("`%s` is longer than 3 days!", durationString), true)
+		return sendEmbed(e, embed, nil)
+	}


I'd separate this into a validateDuration function, and use that function as well in handleSelfTimeoutCommandConfirm instead of L68-74 there.

Vuks69 · 2026-10-04T09:34:45Z

+	if e.GuildID() == nil {
+		embed = selfTimeoutCommandEmbed("Command unavailable!", "This command can only be used in servers!", true)
+		return sendEmbed(e, embed, nil)
+	}


This could be a separate requiresGuild function somewhere in Core, many commands will need that check as well.

Vuks69 · 2026-10-04T09:38:08Z

+	// Ensure ms/ns times are not accepted
+	duration = duration.Round(time.Second)


The comment says "Ensure ms/ns times are not accepted", but nothing rejects them; Round(time.Second) silently truncates. The confirm prompt echoes the raw 1h0m0.4s while the button carries 1h0m0s. Sub-second input is rejected only incidentally, by the 10s floor.

validateDuration could return the normalized/truncated duration so we don't have that discrepancy too. durationString needs to be overwritten here.

Vuks69 · 2026-10-04T09:41:57Z

+		WithColor(color)
+}
+
+// helper to send discord message with the image


Not seeing an image anywhere (copypaste?), also doc comments should be full sentences (uppercase start, end with dot).

Vuks69 · 2026-10-04T09:43:37Z

+	return err
+}
+
+// same as sendEmbed but for button handlers


describes the wrong difference, the real one is that it edits a message and force-clears components

Vuks69 · 2026-10-04T09:46:07Z

+func selfTimeoutCommandEmbed(title string, desc string, isError bool) discord.Embed {
+	var color int
+	if isError {
+		color = 0xff0000 // red
+	} else {
+		color = 0xffc34d // yellow-ish orange
+	}
+
+	return discord.NewEmbed().
+		WithTitle(title).
+		WithDescription(desc).
+		WithColor(color)
+}


I think separating this out into selfTimeoutEmbed/selfTimeoutErrorEmbed like tldr would be more readable on invocations.

Vuks69 · 2026-10-04T09:51:15Z

+
+	durationString, durationProvided := interaction.OptString("duration")
+	if !durationProvided {
+		embed = selfTimeoutCommandEmbed("Unset duration", "duration was not set!", true)


error message typo (capitalization)

Vuks69 · 2026-10-04T09:53:42Z

+func handleSelfTimeoutCommandGoback(data discord.ButtonInteractionData, e *handler.ComponentEvent) error {
+	// overwrite the original message
+	embed := selfTimeoutCommandEmbed("Timeout Cancelled", "See you around!", false)
+	return updateEmbed(e, embed)
+}
+
+func handleSelfTimeoutCommandConfirm(data discord.ButtonInteractionData, e *handler.ComponentEvent) error {


$ pre-commit run --all (snip...) custom-gcl (golangci-lint + NilAway).....................................Failed - hook id: custom-gcl - exit code: 1 internal/moderation/self_timeout.go:61:37: unused-parameter: parameter 'data' seems to be unused, consider removing or renaming it as _ (revive) func handleSelfTimeoutCommandGoback(data discord.ButtonInteractionData, e *handler.ComponentEvent) error { ^ internal/moderation/self_timeout.go:67:38: unused-parameter: parameter 'data' seems to be unused, consider removing or renaming it as _ (revive) func handleSelfTimeoutCommandConfirm(data discord.ButtonInteractionData, e *handler.ComponentEvent) error { ^ 2 issues: * revive: 2

Suggested change

func handleSelfTimeoutCommandGoback(data discord.ButtonInteractionData, e *handler.ComponentEvent) error {

// overwrite the original message

embed := selfTimeoutCommandEmbed("Timeout Cancelled", "See you around!", false)

return updateEmbed(e, embed)

}

func handleSelfTimeoutCommandConfirm(data discord.ButtonInteractionData, e *handler.ComponentEvent) error {

func handleSelfTimeoutCommandGoback(_ discord.ButtonInteractionData, e *handler.ComponentEvent) error {

// overwrite the original message

embed := selfTimeoutCommandEmbed("Timeout Cancelled", "See you around!", false)

return updateEmbed(e, embed)

}

func handleSelfTimeoutCommandConfirm(_ discord.ButtonInteractionData, e *handler.ComponentEvent) error {

Uniolo1 · 2026-10-04T12:48:54Z

Overall pretty well executed, just some inconsistencies.

I amended my PR, should have addressed your issues (hopefully I didn't mess up anything when rebasing)

Fixes Neon-Genesis-Linux#26 AI Usage disclosure: Stack overflow was down while I was working on part of this, so I used it to **ask** how to check if the duration is between a specific window and how to format a string. I just used chatgpt. AI Usage disclosure (Vuks edition): Vuks used opencode's big pickle model inorder to fix some issues with this commit (all the long comments are from the AI) Assisted-by: chatgpt Assisted-by: opencode's big pickle model Co-authored-by: dearfenane <302284256+dearfenane@users.noreply.github.com> Co-authored-by: Vuks69 <51289041+Vuks69@users.noreply.github.com> Signed-off-by: Uniolo1 <89284448+Uniolo1@users.noreply.github.com>

Uniolo1 force-pushed the main branch from cf0cc43 to 54a2bb1 Compare October 3, 2026 23:51

dearfenane suggested changes Oct 4, 2026

View reviewed changes

Uniolo1 force-pushed the main branch from 54a2bb1 to 51ac3a2 Compare October 4, 2026 00:06

Uniolo1 requested a review from dearfenane October 4, 2026 00:06

dearfenane reviewed Oct 4, 2026

View reviewed changes

Uniolo1 force-pushed the main branch from 652fc43 to ede399c Compare October 4, 2026 00:08

Uniolo1 requested a review from dearfenane October 4, 2026 00:08

Uniolo1 force-pushed the main branch 2 times, most recently from 79eee51 to 6cd7de7 Compare October 4, 2026 00:14

dearfenane suggested changes Oct 4, 2026

View reviewed changes

Uniolo1 force-pushed the main branch from 985c674 to 3d2246f Compare October 4, 2026 00:39

Uniolo1 force-pushed the main branch from d153917 to 8e76bdd Compare October 4, 2026 00:42

dearfenane suggested changes Oct 4, 2026

View reviewed changes

Comment thread internal/moderation/self_timeout.go Outdated

Uniolo1 force-pushed the main branch from d4ce048 to 0cf2d75 Compare October 4, 2026 00:46

dearfenane approved these changes Oct 4, 2026

View reviewed changes

Uniolo1 marked this pull request as draft October 4, 2026 02:16

Uniolo1 marked this pull request as ready for review October 4, 2026 02:27

Vuks69 reviewed Oct 4, 2026

View reviewed changes

Uniolo1 force-pushed the main branch from 0254252 to 8fa055e Compare October 4, 2026 12:47

Uniolo1 force-pushed the main branch from 8fa055e to 6d76750 Compare October 4, 2026 18:33

Uniolo1 requested a review from Vuks69 October 4, 2026 19:06

Uniolo1 force-pushed the main branch 3 times, most recently from 4e54e2d to 045c314 Compare October 4, 2026 19:47

Vuks69 force-pushed the main branch from 045c314 to 9c3bffd Compare October 4, 2026 20:50

Uniolo1 force-pushed the main branch from 9c3bffd to c1c8d0f Compare October 4, 2026 20:56

Vuks69 merged commit 18ead09 into Neon-Genesis-Linux:main Oct 4, 2026

		// Ensure ms/ns times are not accepted
		duration = duration.Round(time.Second)

Conversation

Uniolo1 commented Oct 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

AI Usage disclosure

Tests and stuff

Uh oh!

dearfenane left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uniolo1 commented Oct 4, 2026

Uh oh!

dearfenane left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dearfenane commented Oct 4, 2026

Uh oh!

Uniolo1 commented Oct 4, 2026

Uh oh!

dearfenane left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dearfenane left a comment

Choose a reason for hiding this comment

Uh oh!

Uniolo1 commented Oct 4, 2026

Uh oh!

Vuks69 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uniolo1 Oct 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uniolo1 commented Oct 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Uniolo1 commented Oct 3, 2026 •

edited

Loading

Uniolo1 Oct 4, 2026 •

edited

Loading