Make prop_physics_override use CPhysicsPropMultiplayer#2013
Open
DESTROYGIRL wants to merge 1 commit into
Open
Conversation
Member
|
Is there any demo or informal bug report/repro steps of the bug this fix is targeting anywhere? |
Contributor
Author
There's no solid repro steps other than jump around on them a bunch. Video examples from ntre_rise_ctg before they were fixed (not mine): risechair.mp4NEOTOKYOREBUILD_-_2026-02-21_11-43-53_AM.mp4If you load the original nt_rise_ctg, they should have the same behaviours I think |
Contributor
|
What was the map fix for this? |
Contributor
Author
They are no longer physics props, since they never moved in the first place |
AdamTadeusz
approved these changes
Jul 9, 2026
AdamTadeusz
left a comment
Contributor
There was a problem hiding this comment.
Can't replicate the issue on either version but I also don't see any issues with merging this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a somewhat blind attempt to fix the issue where players will be teleported when touching
prop_physics_overrideprops. I couldn't replicate the issue in testing.The reasoning behind this change is that almost all physics props in the game are, or should be
prop_physics_multiplayer. This is because this entity class handles physics differently to avoid issues in multiplayer.prop_physics_overridedoesn't have this, and therefore I believe it's the reason we see issues with them but not other props.I can't think of any scenarios that exist currently where a
prop_physics_overridewould need to be aCPhysicsPropto function correctly. The game is multiplayer at it's core so I don't think this change will have any major negative impact.Toolchain