Skip to content

Make prop_physics_override use CPhysicsPropMultiplayer#2013

Open
DESTROYGIRL wants to merge 1 commit into
NeotokyoRebuild:masterfrom
DESTROYGIRL:65_phys_override_multiplayer
Open

Make prop_physics_override use CPhysicsPropMultiplayer#2013
DESTROYGIRL wants to merge 1 commit into
NeotokyoRebuild:masterfrom
DESTROYGIRL:65_phys_override_multiplayer

Conversation

@DESTROYGIRL

Copy link
Copy Markdown
Contributor

Description

This is a somewhat blind attempt to fix the issue where players will be teleported when touching prop_physics_override props. I couldn't replicate the issue in testing.
The reasoning behind this change is that almost all physics props in the game are, or should be prop_physics_multiplayer. This is because this entity class handles physics differently to avoid issues in multiplayer. prop_physics_override doesn't have this, and therefore I believe it's the reason we see issues with them but not other props.

I can't think of any scenarios that exist currently where a prop_physics_override would need to be a CPhysicsProp to function correctly. The game is multiplayer at it's core so I don't think this change will have any major negative impact.

Toolchain

  • Windows MSVC VS2022

@DESTROYGIRL DESTROYGIRL added this to the Bug Cleanup milestone Jul 8, 2026
@DESTROYGIRL DESTROYGIRL requested a review from a team July 8, 2026 16:20
@DESTROYGIRL DESTROYGIRL added the Mapping Entities, inputs and outputs. Things that are set up in the world editor label Jul 8, 2026
@Rainyan

Rainyan commented Jul 8, 2026

Copy link
Copy Markdown
Member

Is there any demo or informal bug report/repro steps of the bug this fix is targeting anywhere?

@DESTROYGIRL

Copy link
Copy Markdown
Contributor Author

Is there any demo or informal bug report/repro steps of the bug this fix is targeting anywhere?

There's no solid repro steps other than jump around on them a bunch. Video examples from ntre_rise_ctg before they were fixed (not mine):

risechair.mp4
NEOTOKYOREBUILD_-_2026-02-21_11-43-53_AM.mp4

If you load the original nt_rise_ctg, they should have the same behaviours I think

@AdamTadeusz

Copy link
Copy Markdown
Contributor

What was the map fix for this?

@DESTROYGIRL

Copy link
Copy Markdown
Contributor Author

What was the map fix for this?

They are no longer physics props, since they never moved in the first place

@AdamTadeusz AdamTadeusz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't replicate the issue on either version but I also don't see any issues with merging this

@AdamTadeusz AdamTadeusz requested a review from a team July 9, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mapping Entities, inputs and outputs. Things that are set up in the world editor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants