Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
PRIVATE_NETWORKS) covering RFC 1918 (10.0.0.0/8,172.16.0.0/12,192.168.0.0/16), IPv4 loopback/link-local (127.0.0.0/8,169.254.0.0/16), and IPv6 loopback/link-local/ULA (::1/128,fe80::/10,fc00::/7).ip_obj.is_privateinis_private_ip()to prevent documentation/test address blocks like RFC 5737 (203.0.113.0/24) from being incorrectly classified as private networks..gitignoreignoring IDE and test artifact caches.Testing
Ran unit tests verifying RFC 1918 addresses are recognized as private and documentation/public IPs pass through:
All 6 tests passed.