Repository navigation
fix(fileutil): handle decoding errors when inspecting profile files - #183
Open
reginaldalfret wants to merge 1 commit into
Open
reginaldalfret wants to merge 1 commit into
reginaldalfret wants to merge 1 commit into
Conversation
Fixes Netflix#182 Signed-off-by: reginaldalfret <reginaldalfret@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where
_is_perf_fileinfileutil.pyraises an unhandledUnicodeDecodeError(orIOError) when reading files containing invalid UTF-8 bytes or corrupted data inPROFILE_DIR.Problem
_is_perf_fileiterates over file lines without catching decoding exceptions. When an unreadable or non-UTF8 file is present inPROFILE_DIR,UnicodeDecodeErrorpropagates up throughget_profile_type, causing the home page request to fail. Furthermore, the file handle was not guaranteed to be closed when exceptions occurred.Solution
Safeguard the line-reading loop in
_is_perf_filewith atry...except...finallyblock. Catch anyExceptionand returnFalse, ensuring the file stream is always cleanly closed infinally.Testing
test_is_perf_file_unreadable_bytesintests/test_fileutil.py.pytest tests/test_fileutil.py.Fixes #182