Repository navigation
Conversation
SimpleHttpServer registers its handler at /mslcli-server, but the five example client scripts pass -url http://localhost:8080/msl, so they fail against the server they are meant to drive. Update the URLs to match.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mslcli example server registers its handler at
/mslcli-server:and line 60 logs that same path on startup.
Five of the six scripts in
examples/mslcli/client/src/dist/bin/pass-url http://localhost:8080/mslinstead, all on line 6:mslclient_eas-none.sh:6mslclient_eas-none_suffixed.sh:6mslclient_interactive.sh:6mslclient_single_send.sh:6mslclient_with_mslstore.sh:6(The sixth,
mslclient.sh, takes-urlfrom its arguments and hardcodes nothing.)Nothing is registered at
/msl, so these scripts fail against the server they are meant to drive. This PR changes the path to/mslcli-serverin all five. The port is already correct —app.server.port 8080inexamples/mslcli/server/src/dist/bin/mslsrv.cfg:14— so only the path changes.Verification
Run on a machine where port 8080 was already in use, so the server's
app.server.portwas set to 18080 for the test; only the port differs from the shipped configuration.Server started as
mslserver.shinvokes it (mslcli.server.SimpleHttpServer -cfg mslsrv.cfg -eid server1 -eas RSA):The path the scripts use is not registered:
while the registered path answers:
Using
mslclient_single_send.sh's exact argument list (-kx DIFFIE_HELLMAN -eid client1 -uid user1 -if request.dat -eas PSK -uas EMAIL_PASSWORD), unchanged except for the URL:with
/msl—with
/mslcli-server—mslclient_eas-none.sh's argument list (-eid client3 -eas NONE -kx ASYMMETRIC_WRAPPED -kxm JWE_RSA) behaves the same way against/mslcli-server:Response: hello from mslcli,Exit Status 0: Success. The remaining three scripts differ from these two only in entity id, key exchange and MSL store arguments, none of which affect the URL, so they were not run individually.The two scripts that pass
-if request.datneed that file to exist in the working directory; that is pre-existing behaviour and unrelated to this change.Nothing else in the repository hardcodes this path.
mslclient_manual.txtdocuments-url <server-url>generically, andinteg-tests/src/main/README.md:9refers tohttp://localhost:8080/msl-integ-tests/, which is a different application and is left alone.