Repository navigation
Contracts: Fix MarketFactory compilation and deployment issues - #1502
Merged
Merged
Conversation
- Netwalls#1347: Load wasm_hash from MARKET_WASM_HASH storage; use ToXdr for market_id preimage; derive salt deterministically from market_id sha256 - Netwalls#1348: Pass all 12 args to Market::initialize with correct types (market_id, Fighter structs, timestamps, addresses, config); add bet_token to ProtocolConfig - Netwalls#1349: Fix invoke_contract argument conversions using IntoVal; refactor get_config and get_treasury as internal helpers taking &Env with public delegators - Netwalls#1350: Fix market_key lifetimes to 'static; update test initialize calls with all required args; fix event assertion API usage Closes Netwalls#1347, Netwalls#1348, Netwalls#1349, Netwalls#1350
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1347
Closes #1348
Closes #1349
Closes #1350