Repository navigation
toContractAmount converts to stroops with float math #660
Description
toContractAmount (src/stellar/contract.ts:77-91) computes amount * STROOPS_PER_TOKEN in IEEE-754 and validates with Number.isSafeInteger. Common decimal inputs produce non-integer floats (passing or throwing unpredictably), and large values exceed MAX_SAFE_INTEGER, silently rounding the amount actually transmitted on-chain.
Expected: perform the conversion with Decimal/BigInt string arithmetic and test round-trips for values like 0.1, 1.1, and large balances.
Activity
yangqingqu commentedon Oct 20, 2026
@yangqingqu has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @yangqingqu to this issue.
Raydev-tech commentedon Oct 20, 2026
@Raydev-tech has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @Raydev-tech to this issue.
maxx-GENIUS commentedon Oct 20, 2026
@maxx-GENIUS has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @maxx-GENIUS to this issue.
maxx-GENIUS commentedon Oct 20, 2026
⚡ Protocol Implementation Blueprint & Production Readiness Proposal
Hi @maintainers, I am ready to implement and ship this issue immediately.
I have reviewed the repository architecture and pre-analyzed the execution path for this task so you don't have to spend any time onboarding or hand-holding:
1. Scope & Execution Boundary
toContractAmount converts to stroops with float mathtoContractAmount converts to stroops with float math.2. Implementation Strategy & Invariants
3. Verification & Quality Assurance Guarantee
cargo testunit and invariant regression suites.4. Turnaround SLA & Track Record
Looking forward to your green light! Ready to branch and ship.
SheyeJDev commentedon Oct 20, 2026
@SheyeJDev has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @SheyeJDev to this issue.
drips-wave commentedon Oct 20, 2026
Congratulations, @SheyeJDev! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.
🧑💻 @SheyeJDev: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.
Warning
When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.
🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.
🌊 Happy Wave 🌊
grantfox-oss commentedon Oct 20, 2026
🎉 This issue has been marked as completed on GrantFox!
@SheyeJDev's PR #708 was approved and merged by @robertocarlous.
🏆 @SheyeJDev: You earned 40 FoxPoints for this contribution! Your current tier: Builder (1,259 total points). Track your full progress on GrantFox.
👏 Great work, @SheyeJDev! Keep contributing to Neurowealth.
drips-wave commentedon Oct 20, 2026
This issue has been completed by @SheyeJDev as part of the Stellar Wave Program's 10th Wave 🥳
😎 @SheyeJDev: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.
🧑💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.