Skip to content

fix: stale prisma client, admin auth guards, env policy, and repo hygiene CI - #633

Merged
Abidoyesimze merged 2 commits into
Neurowealth:mainfrom
chinoyenmose:fix/repo-hygiene-env-prisma-tests-583-584-585-586
Oct 20, 2026
Merged

Abidoyesimze merged 2 commits into
Neurowealth:mainfrom
chinoyenmose:fix/repo-hygiene-env-prisma-tests-583-584-585-586

Conversation

@chinoyenmose

Copy link
Copy Markdown
Contributor

Closes #583
Closes #584
Closes #585
Closes #586

What changed

Why

  • Admin handlers could be called without identity and returned 500 (leaking stack traces) instead of 401
  • Stale Prisma client caused TS2339/TS2353 compile failures on clean checkouts
  • Tracked .env.* files had no self-documenting gitignore policy or secret scanning
  • One-off contributor artifacts kept landing at repo root

How to test

  • npx jest tests/unit/admin-route-boundaries.test.ts — 67 passed (was 58/67)
  • npx jest tests/integration/analytics/csvExport.integration.test.ts — 6 passed
  • npm test now runs prisma generate first via pretest
  • CI workflows validate env secrets and repo hygiene on PRs
  • Pre-existing test failures (47, down from 56) remain and are tracked separately

Note: Pre-push hook still fails on pre-existing test failures documented in #583. This PR reduces failures from 56 to 47. Remaining failures (migrationProcess rollback.sql gaps, secrets config tests, referral mocks, etc.) need separate fixes.

@drips-wave

drips-wave Bot commented Oct 20, 2026

Copy link
Copy Markdown

@chinoyenmose Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Abidoyesimze
Abidoyesimze merged commit e8e1af5 into Neurowealth:main Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants