Repository navigation
fix: stale prisma client, admin auth guards, env policy, and repo hygiene CI - #633
Merged
Abidoyesimze merged 2 commits intoOct 20, 2026
Conversation
|
@chinoyenmose Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #583
Closes #584
Closes #585
Closes #586
What changed
getAdminAuthfail-closed guard to 9 erasure/referral admin handlers that returned 500 instead of 401 without identity; widenlogBackgroundJob/recordBackgroundJobstatus type to acceptdry_run(fixes 4 suites that couldn't compile)pretestscript runningnpx prisma generateautomatically beforenpm test; addprisma generatetoprebuildpipeline.gitignorenegations for.env.development,.env.production,.env.test; addenv-secret-scan.ymlCI workflow scanning tracked.env*files for high-entropy secret patternsrepo-hygiene.ymlCI workflow rejecting PR clutter files at repo root (PR_*SUMMARY*.md,IMPLEMENTATION_SUMMARY.md,*FIX*.md,*GUIDE*.md,verify_*.sh,fix-*.sh,docs/superpowers/plans/); document policy in CONTRIBUTING.mdWhy
.env.*files had no self-documenting gitignore policy or secret scanningHow to test
npx jest tests/unit/admin-route-boundaries.test.ts— 67 passed (was 58/67)npx jest tests/integration/analytics/csvExport.integration.test.ts— 6 passednpm testnow runsprisma generatefirst viapretestNote: Pre-push hook still fails on pre-existing test failures documented in #583. This PR reduces failures from 56 to 47. Remaining failures (migrationProcess rollback.sql gaps, secrets config tests, referral mocks, etc.) need separate fixes.