Repository navigation
fix: script secret leakage, TOTP throttling, impersonation audit, attachment IDOR - #634
Merged
Abidoyesimze merged 1 commit intoOct 20, 2026
Conversation
…achment IDOR Closes Neurowealth#587 Closes Neurowealth#590 Closes Neurowealth#605 Closes Neurowealth#606
|
@unlimitedengineer Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #587
Closes #590
Closes #605
Closes #606
DATABASE_URLbefore printing inrehearse-migration-rollback.shandrollback-migration.sh(${VAR##*@}extracts host-only); extendenv-secret-scan.ymlto also scanscripts/and.github/workflows/for secret variable echo patterns on every PRAdminAuditLogentries on impersonation start and end (action, target user, IP, session ID, reason); addblockHighRiskImpersonationmiddleware that denies impersonated tokens on withdrawals, erasure, API key management, treasury, MFA/TOTP routes; propagateipAddressandreasonthroughgenerateImpersonationTokentotp.service.ts: 5-attempt lockout with 15-minute cooldown, constant-time code comparison viatimingSafeEqual, time-step replay prevention, audit log on every failed attempt, andunlockTotpCredentialadmin helperattachmentRefsin all support ticket validators; addvalidateAttachmentRefsownership check in create and reply handlers with IDOR logging; document MIME/size/scan policy for the upload endpoint