Repository navigation
feat!: add required CreateDatasetFromCsvRequest param to InputStream overloads - #34
Merged
Merged
Conversation
Generated by Fern CLI Version: unknown Generators: - fernapi/fern-java-sdk: 4.32.4
…ram to InputStream overloads The `createDatasetFromCsv` InputStream overloads in both `DatasetsClient` and `AsyncDatasetsClient` now require a `CreateDatasetFromCsvRequest` as the first parameter. Callers using the old `(InputStream, String)` or `(InputStream, String, MediaType/RequestOptions)` signatures must update their call sites to pass a `CreateDatasetFromCsvRequest` object as the first argument. Additionally, all async methods in `AsyncDatasetsClient` now properly propagate cancellation from the derived future back to the underlying raw HTTP future, improving resource cleanup on cancellation. Key changes: - `DatasetsClient.createDatasetFromCsv(InputStream, String[, ...])` — now requires `CreateDatasetFromCsvRequest` as first parameter (breaking) - `AsyncDatasetsClient.createDatasetFromCsv(InputStream, String[, ...])` — same signature change (breaking) - All `AsyncDatasetsClient` async methods now propagate `cancel()` to the underlying raw future via `whenComplete` 🌿 Generated with Fern
Kizy625
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking: MAJOR because
createDatasetFromCsv()InputStream overloads on all four clients (DatasetsClient,AsyncDatasetsClient,RawDatasetsClient, andAsyncRawDatasetsClient) now require a new leadingCreateDatasetFromCsvRequestparameter, breaking all existing call sites that omit it.Breaking Changes
DatasetsClient.createDatasetFromCsv()— all InputStream overloads now require aCreateDatasetFromCsvRequestas the first argument; replacecreateDatasetFromCsv(stream, filename, ...)withcreateDatasetFromCsv(request, stream, filename, ...).AsyncDatasetsClient.createDatasetFromCsv()— same signature change as the synchronous client; prepend aCreateDatasetFromCsvRequestargument beforestreamandfilenameat every call site.RawDatasetsClient.createDatasetFromCsv()— all four overloads now require a leadingCreateDatasetFromCsvRequestparameter so thatnameanddescriptionare sent as multipart form fields; add aCreateDatasetFromCsvRequestas the first argument to every call site.AsyncRawDatasetsClient.createDatasetFromCsv()— all four overloads now require a leadingCreateDatasetFromCsvRequestparameter; update every call site to prepend aCreateDatasetFromCsvRequestargument.Added
RequestOptions.Builder.addBodyProperty()/bodyProperties()— new builder methods that inject arbitrary key/value pairs into the JSON or form-urlencoded request body, overriding any existing property with the same key.RetryInterceptor.newAsyncCall()— new static factory that creates a non-blocking async call with built-in retry support, preventing OkHttp dispatcher slot exhaustion and enabling immediate cancellation.Stream.fromSseWithEventDiscrimination()— new static factory for SSE streams that supports envelope-level event discrimination, deserializing specified event names from the full SSE envelope rather than just thedatapayload.PathSegments.validate()— new core utility that rejects"."and".."as path parameter values, preventing silent URL path traversal.Changed
AsyncDatasetsClient— all async methods now propagateCompletableFuturecancellation to the underlying HTTP call, ensuring in-flight requests are properly cancelled.@JsonAnySetternow filters out known property keys on all request types (e.g.,CreateDatasetRequest,UpdateDatasetRequest,ListDatasetsRequest, and others), preventing typed fields from being silently overwritten during deserialization.RawDatasetsClient— path segment values fordatasetIdare now validated viaPathSegments.validate()and extra body properties fromRequestOptionsare merged into every JSON request body.See full changelog