Skip to content

fix: product api types - #527

Merged
valentinludu merged 1 commit into
devfrom
fix/products-api-types
Aug 27, 2026
Merged

valentinludu merged 1 commit into
devfrom
fix/products-api-types

Conversation

@valentinludu

@valentinludu valentinludu commented Aug 27, 2026 •

Copy link
Copy Markdown
Contributor

Add the right types for products and product types api

Summary by CodeRabbit

  • New Features

    • Added support for richer product information, including terms and conditions, deprecation status, coverage limits, priority pools, and purchase disclaimers.
    • Expanded purchase form options to support free-text and TRM inputs.
    • Added support for structured product metadata, rich-text content, and API-key service requirements.
  • Bug Fixes

    • Improved claim method handling for consistent product configuration.

@valentinludu
valentinludu requested a review from mixplore August 27, 2026 09:27
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4d98154
Status: ✅  Deploy successful!
Preview URL: https://91cf2ec0.sdk-9yp.pages.dev
Branch Preview URL: https://fix-products-api-types.sdk-9yp.pages.dev

View logs

@coderabbitai

coderabbitai Bot commented Aug 27, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7d97c89c-739a-4499-822b-3cadfc58b22f

📥 Commits

Reviewing files that changed from the base of the PR and between 47b44b6 and 4d98154.

📒 Files selected for processing (2)
  • src/quote/getQuoteAndBuyCoverInputs.test.ts
  • src/types/product.ts

Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Walkthrough

Walkthrough

The PR expands product and product-type declarations with form inputs, content, metadata, API-key services, and additional product fields. It also changes claimMethod to a string and updates the related test fixture.

Changes

Product type contracts

Layer / File(s) Summary
Product type inputs and claim method
src/types/product.ts, src/quote/getQuoteAndBuyCoverInputs.test.ts
Adds product form, rich-text, IPFS, and buy-cover form types. Expands ProductType fields and changes claimMethod to string. Updates the test fixture to use '0'.
Product metadata and services
src/types/product.ts
Adds product metadata and API-key service types. Updates Product.metadata and adds API-key, AUM, cover amount, priority pool, and disclaimer fields.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 4d981

This localized type update has no identified merge-blocking risk and is merge-ready after normal checks and review.

Suggested reviewers: mixplore

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: correcting product API types. It is concise and related to the changeset.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/products-api-types
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/products-api-types

Comment @coderabbitai help to get the list of available commands.

@valentinludu
valentinludu merged commit 1b6681b into dev Aug 27, 2026
3 checks passed
@valentinludu
valentinludu deleted the fix/products-api-types branch August 27, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants