Repository navigation
fix(deps): remove unused svgo and pin ci node to 22.23.4 - #529
Merged
Merged
Conversation
svgo 3.0.2 was a runtime dependency with four high and one moderate advisory (GHSA-xpqw-6gx7-v673, GHSA-2p49-hgcm-8545, GHSA-w27v-7q3p-w38r, GHSA-4vpr-x523-8j87) and pulled in a vulnerable source-map-js. Nothing in the repo imports it, so drop it rather than upgrade. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Node 22.23.4 fixes the October 21 2026 security release, including the Brotli decoder RCE (CVE-2026-111497) reachable through fetch. A floating `22` lets setup-node reuse an older cached runner version, so read an exact version from .nvmrc, which also serves local nvm users. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly and concisely describes both primary changes: removing the unused svgo dependency and pinning CI to Node.js 22.23.4. |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
✨ Simplify code
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Deploying sdk with
|
| Latest commit: |
451b145
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ddc172d3.sdk-9yp.pages.dev |
| Branch Preview URL: | https://fix-node-security-release-sv.sdk-9yp.pages.dev |
valentinludu
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the Node.js security release of 2026-10-21, plus removal of the only vulnerable package that reaches SDK consumers.
None of the npm advisories published on 2026-10-21 (Vite, Vitest, Storybook, ApostropheCMS, sanitize-html, Electron, OpenClaw) appears in our lockfile.
Changes
Remove
svgofromdependencies.svgo@3.0.2had 4 high and 1 moderate advisory (GHSA-xpqw-6gx7-v673, GHSA-2p49-hgcm-8545, GHSA-w27v-7q3p-w38r, GHSA-4vpr-x523-8j87) and pulled in a vulnerablesource-map-js@1.0.2. Nothing in the repo imports it. It came in with8f4c538when the logos were merged in. Removing it takes 18 packages out of the tree.Pin CI Node to 22.23.4 through a new
.nvmrc. 22.23.4 is the patched 22.x release for the October 2026 Node.js security release. It fixes CVE-2026-111497 (a Brotli decoder RCE thatfetchcan reach) and CVE-2026-106069 (a TLS hostname check bypass). Withnode-version: 22,setup-nodecan reuse an older 22.x cached on the runner. All four workflows now usenode-version-file: .nvmrc, and theNODE_VERSIONenv vars are removed.Notes
pnpm audit --prodnow reports no known vulnerabilities. The remaining audit findings are in dev-only dependencies, which don't ship in the package.prep-latestchecks outmaster, but only afterff-masterhas fast-forwardeddev, so.nvmrcis there by the time it's read.enginesstays at>=22.0.0.NexusMutual/workflowsrepo wasn't checked for its own Node version.Testing
pnpm run ts:check-types,pnpm run build,pnpm test: all pass (258 tests)pnpm audit --prod: clean🤖 Generated with Claude Code
Summary by CodeRabbit