Skip to content

fast-forward reads an input it never declares #22

Open

Description

@roxdanila

fast-forward.yml declares environment, source-ref and target-ref. Line 36 passes repository: ${{ inputs.repository }} to actions/checkout.

The expression resolves to an empty string, and checkout falls back to the repository running the workflow. That happens to be what every caller wants, so the step works by accident.

Reproduce: actionlint -shellcheck= .github/workflows/fast-forward.yml

fast-forward.yml:36:27: property "repository" is not defined in object type
{environment: string; source-ref: string; target-ref: string} [expression]

Fix: drop the line, or declare a repository input and default it to ${{ github.repository }}.

Found while reviewing #20. Reported by actionlint, which #21 proposes adding to CI.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions