Remove the ai.nimblebrain/context attach and the navigate/startChat actions - #103
Merged
Merged
Conversation
sendMessage sends the spec's text block alone. What the user is acting on reaches the agent through updateModelContext, which the NimbleBrain host attaches to the next turn. The NimbleBrain host serves openApp and openConversation; startChat is sendMessage and navigate is openApp or openLink.
Contributor
Author
QA Review: bridge-context-and-actionScope: 17 files, +55/−144 · worktree: Critical (must fix)None. Fix in-PR (apply mechanically — no adjudication essay expected)
Suggestions (optional)None. What Looks Good
Body claims
Next step: the author answers with pr-adjudicate. The Critical bucket is empty, so this PR qualifies for machine record{
"kind": "review", "pr": 103, "round": 1,
"reviewed": "34f4c9006a04b0a8be5165d209df455017a2f1fc", "delta_base": null,
"risk": "LOW", "stop_gate": "n/a",
"verdict": "Correct subtraction; one CHANGELOG sentence depends on the runtime companion deploying first",
"findings": [
{"id": "r1f1", "bucket": "fix-in-pr", "file": "CHANGELOG.md", "line": 11,
"claim": "CHANGELOG states the host already ignores the chat context and navigate/startChat; runtime main still reads both",
"evidence": "reproduced",
"receipt": "git grep on nimblebrain origin/main: AppWithChat.tsx:132 builds [App Context] prefix; App.tsx:590 startChat handler",
"preconditions": null,
"fix": "release after nimblebrain#1278 deploys, or reword without the past-tense claim",
"scope": "peripheral"}
]
} |
Contributor
Author
Adjudication round 1: one fix applied, nothing contested · fixed at aac0987Fix in-PRr1f1 applied in VerificationCI run 36273293753 is green at machine record{
"kind": "adjudication", "pr": 103, "round": 1,
"fixed_at": "aac098791d0d23f31de34a7e67b648ec1ec0362e",
"verdicts": [
{"id": "r1f1", "verdict": "valid", "premise": "verified",
"resolution": "reworded CHANGELOG to drop the shipped-host claims, aac0987"}
],
"ci": "success, run 36273293753"
} |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SDK side of retiring two NimbleBrain host extensions. Companion runtime PR: NimbleBrainInc/nimblebrain (bridge-context-and-action).
sendMessage(text, context)losescontext. Theai.nimblebrain/contextkey it attached is retired, and the spec'sui/update-model-contextcarries app state instead. Migration: callupdateModelContext({ … }), thensendMessage(text).action()supportsopenAppandopenConversationonly.startChatduplicatedui/message, andnavigatecoupled apps to the host's URL layout.Breaking: the next release should be a minor bump (0.22.0). Not bumped or tagged here.
Checks:
npm run cipasses (561/561), conformance passes (36/36), and the docs build passes.