Syntax review#446
Open
ABuljko wants to merge 3 commits into
Open
Conversation
ABuljko
requested review from
daringer,
james-knippes,
mmerklinger,
robin-nitrokey and
sosthene-nitrokey
and removed request for
a team
Contributor
Author
|
@robin-nitrokey should I ignore the errors for now since they are appearing because the GitHub Actions environment doesn't have Python 3.11+ installed 🤔 👀 Should I put it back to 3.10? |
robin-nitrokey
left a comment
robin-nitrokey
left a comment
Member
There was a problem hiding this comment.
should I ignore the errors for now since they are appearing because the GitHub Actions environment doesn't have Python 3.11+ installed 🤔 👀
You can update the container used in the CI from python:3.10-slim to python:3.11-slim.
Member
|
Thanks for the fixes! Please rebase onto main and squash the changes into one commit with a descriptive commit message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.