Add minimum dependency age#762
Merged
Merged
Conversation
sosthene-nitrokey
requested review from
daringer,
james-knippes,
mmerklinger and
robin-nitrokey
and removed request for
a team
sosthene-nitrokey
force-pushed
the
min-age
branch
from
6a9396c to
2a813e9
Compare
sosthene-nitrokey
changed the title
sosthene-nitrokey
force-pushed
the
min-age
branch
from
2a813e9 to
b6f1b04
Compare
This already uses solver.min-release-age = 7 as proposed in Nitrokey#762.
This adds a configuration so that poetry, uv and pip don't consider releases that are less than 7 days old to reduce the risk of installing malware through simple dependency update. This PR also adds an exclusion for the `nitrokey` package, as it's most likely that a compromise to the `nitropy` package would mean our python packages can all be compromised, and `nitropy` and `nitrokey-app2` are generally updated in sync with the sdk.
sosthene-nitrokey
force-pushed
the
min-age
branch
from
b6f1b04 to
85a6252
Compare
Contributor
Author
|
I disabled the minimum age for the CI |
robin-nitrokey
approved these changes
Jun 19, 2026
sosthene-nitrokey
force-pushed
the
min-age
branch
from
85a6252 to
82633cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a configuration so that poetry, uv and pip don't consider releases that are less than 7 days old to reduce the risk of installing malware through simple dependency update.
This PR also adds an exclusion for the
nitrokeypackage, as it's most likely that a compromise to thenitropypackage would mean our python packages can all be compromised, andnitropyandnitrokey-app2are generally updated in sync with the sdk.