Repository navigation
fix(backend): resolve syntax errors in routes, batchController, and zkpVerifierService - #1373
Merged
Merged
Conversation
…kpVerifierService - Remove duplicate declarations of protect, adminOnly, authorizeIoTSubmission, batchLimiter, and iotLimiter in backend/routes/index.js - Remove dangling .catch line after try-catch block in backend/controllers/batchController.js - Correct path.join argument in backend/services/zkpVerifierService.js Closes #1363
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
🚀 Impressive! A new contribution to CropChain! Thank you for your Pull Request. To help us merge this smoothly, please ensure:
We will review your code soon. Happy building! 🌾✨ |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Overview
This PR resolves three critical syntax errors in the backend that prevented the server from starting and broke 18 Jest test suites:
backend/routes/index.js: Removed redundant destructuring imports on lines 12-13 which redeclaredprotect,adminOnly,authorizeIoTSubmission,batchLimiter, andiotLimiter.backend/controllers/batchController.js: Removed stray.catch(...)line 807 appended after atry ... catchblock inbulkUpdateBatchStatus.backend/services/zkpVerifierService.js: Fixed malformedpath.join(__ environment || __dirname, ...)expression to standardpath.join(__dirname, ...).🔗 Related Issue
Closes #1363
🧪 Testing & Verification
node -c backend/routes/index.js(passed)node -c backend/controllers/batchController.js(passed)node -c backend/services/zkpVerifierService.js(passed)npx jest tests/activityApi.test.js(passed 3/3)npx jest tests/batchSearchRegex.test.js(passed 2/2)