docs(ops): make the deposit-enumeration pre-check trustworthy - #126
Merged
Conversation
The pre-check said this needed an indexed RPC because a 2M-block eth_getLogs would not complete on a public endpoint. Wrong reason, and the real one is worse: publicnode rejects archive log queries with "Archive requests require a personal token", and cast logs surfaces that rejection as [] with exit 0. A silent empty result is indistinguishable from "no deposits", so running this pre-check on a free endpoint reads as a clean pass while skipping any refundable failed deposit. Record what each public endpoint actually does, give a known-present log to sanity-check a zero against, and provide a working Etherscan invocation plus the L2 receipt follow-up. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
LCOV of commit
|
Unblock PR CI by adding publicnode/drpc/apikey to cspell and using US spelling in the deposit pre-check endpoint table. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #124. I tried to actually run the deposit-enumeration pre-check and found the guidance I wrote there was wrong — and wrong in the direction that produces a false pass.
What #124 said
Wrong reason. The range completes fine. The actual problem is that the bridge deployed at block 23579563, so any full-history scan is an archive request, and free endpoints refuse those — several of them silently.
What actually happens
eth_getLogsethereum-rpc.publicnode.com-32602 Archive requests require a personal token—cast logsreports this as[]with exit 0eth.drpc.org403on sustained scanningcloudflare-eth.com/rpc.ankr.com/eth/eth.merkle.ioA scan of the old bridge's full history returned
[]forDepositInitiated. That looks like "no deposits, nothing to claim, safe to cut over." It is not a result at all.Proof it was a false negative: the deployment receipt at block 23579563 contains an
OwnershipTransferredlog (0x8be0079c…) emitted by theOwnableconstructor, andeth_getLogsfor that exact single block on the same endpoint returns zero.isWithdrawalFinalized(503366, 17)is alsotrueon the old bridge, soWithdrawalFinalizedevents demonstrably exist — a full-range query for them likewise returned zero.Why it matters
The pre-check exists to catch failed deposits that still need
claimFailedDepositwhile the old bridge holdsMINTER_ROLE. A silent empty result means skipping them and stranding user refunds — the exact failure the pre-check is meant to prevent, reached by appearing to pass.Changes
0x8be0079c…) to sanity-check any zero against before trusting itzks_getTransactionReceiptfollow-up for checking L2 status per depositStatus
The pre-check itself is still not done — it needs a key I don't have. The runbook now makes it runnable in one command and hard to fool.
🤖 Generated with Claude Code