Repository navigation
Conversation
- Removes deprecated code - Improves the reading and writing `long` values - Readds the Color write method (because we're better off having it than not tbh) - Adds a new `INetSerializable` interface that allows types to define how they are read and written - Improves on the generic message converter system to allow multiple type parameters of an arbitrary order - Improves the boxed read method by consolidating a lot of the type checks into a Dictionary key read
XtraCube
reviewed
Oct 8, 2026
| /// Writes the instance to the provided writer. | ||
| /// </summary> | ||
| /// <param name="writer">The <see cref="MessageWriter"/> to write to.</param> | ||
| void WriteTo(MessageWriter writer); |
Contributor
There was a problem hiding this comment.
why not Serialize and Deserialize?
Contributor
Author
There was a problem hiding this comment.
Made more intuitive sense to name them WriteTo and ReadFrom to me
Contributor
Author
|
I'm just confused since I can't really tell what's going in Hazel's reading and writing, instead of using ZigZag encoding, they are just directly casting to and from between I am tempted to do two things, however both seem to not be ideal moves:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INetSerializableinterface that allows types to define how they are read and writtenlongandulongvaluesshortvalueslongvaluesI would recommend merging #102 and #110 first before this so I can account for their respective changes (as I have plans to look over the IL code as a whole)