Repository navigation
fix(aws,gcp,azure): align cloud installation and marketplace setup - #118
Draft
tim-thacker-nullify wants to merge 7 commits into
Draft
tim-thacker-nullify wants to merge 7 commits into
tim-thacker-nullify wants to merge 7 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloud setup guidance disagrees with collector contracts, and GCP grants log-entry access it does not use.
Evidence: three credential-free GCP plans pass on Terraform 1.8.5 and 1.14.8; eight HTTP consumer tests and credential-free gcloud install/uninstall checks pass. A strict Helm dry run preserved four public versions and prepared 0.6.1; chart/RBAC/upload-scope checks pass.
Correctness confidence: moderate-high; collector calls match the narrowed permissions, but live GCP/customer acceptance remains unverified.
Merge risk: medium across IAM and publication workflow changes. Deployment risk is higher: applying Terraform removes an existing grant; customer IAM changes and the prepared release remain unapplied.