Repository navigation
fix(photos): validate orientation option - #102
anmoljauhar1 wants to merge 1 commit into
Conversation
|
Someone is attempting to deploy a commit to the Together AI Team on Vercel. A member of the Team first needs to authorize it. |
Reproduction and verificationBefore this change, running: node skills/hallmark/scripts/theme.mjs photos "mountain landscape" --orient sideways --jsonreturned a successful-looking JSON result with an empty With this change, unsupported non-empty orientation values print the supported values and exit with status 2. The regression tests cover both rejection of Checks run locally:
The current Vercel check is asking for Together AI team authorization; its bot message indicates a team member must authorize the deployment. |
|
Hi maintainers! The local regression tests and validation checks pass. I noticed the GitHub Actions |
Summary
Reject unsupported values passed to
photos --orientinstead of silently returning an empty photo list.Previously, a typo such as
--orient sidewaysproduced valid-looking JSON with"picks": [], which could be mistaken for a search with no matching photos. The CLI now reports the supported values (landscape,portrait,square) and exits with status 2.Changes
--orientagainst the documented values before filtering the photo library.landscapewith matching results.Verification
node --test skills/hallmark/scripts/tests/theme-photos-orient.test.mjs— 2 passednode --check skills/hallmark/scripts/theme.mjs— passednode skills/hallmark/scripts/refcheck.mjs— clean across 101 reference filesnode skills/hallmark/scripts/theme.mjs validate skills/hallmark/references/themes/*.md— all 50 theme files validatedNotes for review
The documented usage lists
landscape|portrait|squareas the supported orientations. Invalid-value behavior is not otherwise explicitly specified, so this PR proposes rejecting unsupported values with a clear message rather than silently producing no results.