Repository navigation
fix(sloplint): deduplicate directory symlinks before recursion - #103
Open
xunguangzlj-cloud wants to merge 2 commits into
Open
xunguangzlj-cloud wants to merge 2 commits into
xunguangzlj-cloud wants to merge 2 commits into
Conversation
|
@xunguangzlj-cloud is attempting to deploy a commit to the Together AI Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linting a project containing a symlink to an ancestor repeatedly traverses the same directories. Multiple directory aliases also cause the same CSS file to be checked more than once, because collection only deduplicates file path strings.
Track visited directories and files by realpath before descending. Valid external directory links remain supported, and reports keep the first discovered path. No dependencies or lint rules change.
Add a regression to the existing refcheck runner that invokes the real CLI on a project with a parent cycle and two links to one shared directory. It must finish and report exactly one file. The fixture uses junctions on Windows and directory symlinks elsewhere, with a five-second subprocess timeout.
Validation:
Local verification used Windows and Node.js 24.16.0. Cross-platform hosted checks are pending. Vercel requires Together AI team authorization for this external contribution; that deployment gate is separate from local validation. Prepared with AI assistance; maintainer review and merge remain pending.