Repository navigation
Run the mechanical width checks at 1440 too - #86
Draft
rudycelekli wants to merge 1 commit into
Draft
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
|
@rudycelekli is attempting to deploy a commit to the Together AI Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
references/responsive.mdsays the mechanical half runs at eight widths, including 1440: horizontal scroll andoverflow-x: clip(34), wrapping controls (49), image tracks and display heads (50), radio tabs (53), stacked sticky elements (56). Gate 34 is "Horizontal scroll at any width 320 to 1920".Those checks live in
observe(), andobserve()only runs onWIDTHS. That array was[320, 375, 414, 768, 1024, 1280, 1920]. The existing1440×900pass callsobserveSpace(), which scores fold and space (F17, F18, 59, 69). It does not run the scroll or wrapping checks, so 1440 was a hole between 1280 and 1920.WIDTHSis now[320, 375, 414, 768, 1024, 1280, 1440, 1920], the same listresponsive.mdnames. Fold, contrast, and the sticky check stay on the 1280 pass (width === 1280). Screenshots stay at 1280 and 375. README already says "eight widths", so it is unchanged.Verified with a node check that the array matches the eight numbers in
responsive.md, and that theobserve()call sits on theWIDTHSloop whileobserveSpace()stays on the separate1440×900/1920×1080loop.