Repository navigation
Read --scope as a flag instead of a slug - #87
Draft
rudycelekli wants to merge 1 commit into
Draft
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
|
@rudycelekli is attempting to deploy a commit to the Together AI Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
theme.mjsreads--scopewithflag(), butscopeis missing fromVALUED, the set of flags whose next token is a value.positional()only skips that next token when the flag is in the set, so the value becomes a positional argument.node theme.mjs scaffold --scope app bloomtherefore looks upreferences/themes/app.mdand exits 1 (no theme at .../themes/app.md). The same leak makesphotos "sea" --scope appsearch for a second subject namedapp.scaffold bloom --scope apphappens to work only because the slug comes first and later positionals are ignored.scopeis now inVALUED, besideredesign.Verified with
theme.mjs:scaffold --scope app bloomwrites Bloom's tokens, the stampshape: app screen, and the fixed app type scale (noclamp).scaffold bloom --scope appstill does.scaffold --scope appwith no slug prints usage and exits 2, instead of looking up a theme namedapp.photos "sea" --n 1 --seed abc --scope app --jsonreturns the subjectseaonly.The app-screens sentence in
flow.mdstill showstheme.mjs scaffold --scope appwith no slug. That command has nothing to scaffold; this change only stopsappfrom being read as the theme.