Repository navigation
fix(sloplint): reject an unknown --tier instead of reporting clean - #93
Closed
techsaurabh-394 wants to merge 1 commit into
Closed
techsaurabh-394 wants to merge 1 commit into
techsaurabh-394 wants to merge 1 commit into
Conversation
--tier took any string. A typo or wrong case (--tier Floor, --tier flor) matched no finding, so the run filtered everything out and printed 'sloplint: clean. 0 FAIL', a false pass from a gate checker. A bare --tier did the same. Validate it with the other options: floor, reflex, finish or ledger, exit 2 otherwise, matching --stage, --genre and --scope. Signed-off-by: Saurabh Pathak <saurabhpathak394@gmail.com>
|
@techsaurabh-394 is attempting to deploy a commit to the Together AI Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sloplint.mjs --tieraccepts any string. A typo or wrong case, such as--tier Flooror--tier flor, matches no finding, every finding is filtered out, and the run printssloplint: clean. 0 FAIL, 0 REFLEX, 0 WARNwith exit 0. A bare--tierwith no value does the same. For a gate checker that is a false pass.This validates
--tiernext to--stage,--genreand--scope: it must befloor,reflex,finishorledger, otherwise it prints--tier must be floor, reflex, finish or ledgerand exits 2.Scope
One file, +1 line. Not included: the unreadable-input exit codes (#89), which touch other lines.
Verification
On
scripts/fixtures/slopped.html:--tier zzz,--tier Floor,--tier ""and--tierwith no value: error message, exit 2 (before the change: "clean", exit 0).--tier floor: 24 FAIL.--tier reflex: 15 REFLEX.--tier finish: 3 WARN.--tier ledger: clean. Same as before the change.--tier: 24 FAIL, 15 REFLEX, 4 WARN, unchanged.node --checkandnode skills/hallmark/scripts/refcheck.mjs: clean across 99 reference files.Not run: render tier, the theme CI steps (themes untouched), and Node 20 (tested on Node 22.19).
Risk / rollback
Low. Only invocations with an invalid
--tierchange, and they now fail loudly. Revert the single commit to undo.