Repository navigation
fix: lint markup inside Hallmark projects - #98
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
|
@rudycelekli is attempting to deploy a commit to the Together AI Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run the edit-time Floor check for HTML/CSS inside a
.hallmarkproject even when the Hallmark comment is in a linked stylesheet. Currently that HTML returns an empty hook response although the real linter finds violations in its stylesheet.The change adds project-marker detection as a fallback for markup. Unmarked components still require a project marker, ordinary unmarked HTML stays ignored, and the existing ancestor-search limit is unchanged.
Validation
The same portable Node process regression fails on unchanged main and passes all four tests with the fix. Tests invoke the actual hook and linter and cover linked stylesheets, ignored unmarked inputs, stamped CSS and the ancestor boundary. They run in the existing verify workflow.
Reference checks (101 files), validation of all 50 themes, index regeneration with no diff, and
git diff --checkpass. These are native local results; hosted CI and any Vercel deployment authorization are pending. No provider or paid service was used.Checked all 66 current/historical PRs and the hook-related changes, including #85 and #92; those address installation/settings rather than this edit-time detection path.
Prepared with AI assistance under the account owner's direction and independently reviewed. Maintainer review and merge remain pending.