Repository navigation
fix(imagegen): reuse complete numbered image batches - #99
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
|
@rudycelekli is attempting to deploy a commit to the Together AI Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reuse a complete image-generation batch instead of requesting it again. With
--n 2, generation writes numbered PNGs, but the cache lookup checks the unnumbered path. A repeat request therefore misses its existing images and can make another provider request.Check each expected numbered output, stop at the first missing file, and return the same
path/pathsshape as fresh generation. Explicit output still requires matching request metadata; partial batches and--forcestill bypass the cache. The lookup allocates only for files actually present.Validation
The same portable tests invoke the actual CLI: unchanged main has two cache failures and four passing controls; this patch passes all six. Coverage includes default and explicit outputs, actual cached PNG content, single images, partial batches, mismatched metadata, force bypass, and a billion-image cache miss under a 32 MiB heap limit. Provider keys are removed from test processes; no generation requests or paid calls were made.
Required local reference checks (101 files), all 50 theme validations, index regeneration without a diff, and diff hygiene pass. The regression runs in the existing Node 20 verify workflow. Local runtime was Node 22; hosted CI is pending and Vercel may separately require team authorization.
Checked all 67 current/historical PRs and cache/imagegen issue overlap. Prepared with AI assistance under the account owner's direction and independently reviewed. Maintainer review and merge remain pending.