Skip to content

[17.0][IMP] website: activate default header for websites using deprecated header layout - #5946

Open
hbrunn wants to merge 1 commit into
OCA:17.0from
hbrunn:17.0-website-deprecated-headers
Open

[17.0][IMP] website: activate default header for websites using deprecated header layout#5946
hbrunn wants to merge 1 commit into
OCA:17.0from
hbrunn:17.0-website-deprecated-headers

Conversation

@hbrunn

@hbrunn hbrunn commented Aug 26, 2026

Copy link
Copy Markdown
Member

No description provided.

@hbrunn hbrunn added this to the 17.0 milestone Aug 26, 2026
@OCA-git-bot OCA-git-bot added mod:openupgrade_scripts Module openupgrade_scripts series:17.0 labels Aug 26, 2026
@pedrobaeza

Copy link
Copy Markdown
Member

I'm not sure about this, as this won't crash, but silently will change totally the format of website layout.

@hbrunn

hbrunn commented Aug 26, 2026

Copy link
Copy Markdown
Member Author

the layout is totally changed because the views in question are deleted during the migration. and then after migration some js crashes because the expected header node doesn't exist, leaving users with a defunct website editor, and they'll have to know that they need to go to the backend and activate one of the existing headers

@pedrobaeza

Copy link
Copy Markdown
Member

Where are they deleted? And you are searching for views matching the website_id field, but they are not the generic or neither exist, isn't it?

@hbrunn

hbrunn commented Aug 26, 2026

Copy link
Copy Markdown
Member Author

Where are they deleted?

ie here

And you are searching for views matching the website_id field, but they are not the generic or neither exist, isn't it?

there will be a website-specific copy of the view because that's what Odoo does when you activate some other header layout, or any other view for that matter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:openupgrade_scripts Module openupgrade_scripts series:17.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants