[16.0][MIG] account_payment_batch_process_discount

[Murtaza-OSI]

No description provided.

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[PauBForgeFlow]

Hi @Murtaza-OSI ! Could you please add test-requirements file to pass tests?
Also, could you rebase PR and delete account_payment_batch_process module? There is a recent version at #564

[marcos-mendez]

Automated Review -- Tests Failed

1. Root Cause

The test failure is caused by a missing or uninstalled dependency module required by the account_payment_batch_process module. Specifically, the error indicates that a module (account_payment_batch_process or a related one) cannot be installed due to missing dependencies, likely account_check_printing or account_payment_order, which are listed in the manifest but not available in the test environment.

2. Suggested Fix

Ensure that all dependencies declared in account_payment_batch_process/__manifest__.py (i.e., account_check_printing and account_payment_order) are installed and available in the test database before attempting to load the registry. If these modules are not part of the standard Odoo 16.0 CE, they must be added to the test environment or the manifest should be updated to reflect only available dependencies.

3. Additional Code Issues

• Missing __init__.py in wizard directory: The account_payment_batch_process/wizard/ directory is imported in __init__.py, but there is no __init__.py file inside the wizard folder. This will cause an import error in Odoo.

  • File: account_payment_batch_process/wizard/__init__.py
  • Fix: Add an empty __init__.py file in the wizard directory.

• Missing model definition for invoice_payment_line: The module defines a model invoice_payment_line in the manifest (wizard/account_payment_register.xml) but does not define it in the models directory. This will lead to a missing model error during runtime.

  • File: account_payment_batch_process/models/__init__.py
  • Fix: Add the invoice_payment_line model in models/ or ensure it's properly defined in the wizard.

4. Test Improvements

To improve test coverage and prevent regression:

• Add a TransactionCase test for account_payment_batch_process module to verify:
  • That the wizard opens correctly with multiple invoices.
  • That batch payments are correctly processed for both customer and vendor invoices.
  • That the system correctly enforces currency consistency across invoices.
  • That the system correctly raises an error when trying to mix customer invoices and vendor bills in one batch.
• Use SavepointCase to test scenarios involving:
  • Partial payments with write-off.
  • Different payment difference handling options (open, reconcile).
  • Access rights for invoice_payment_line and payment_adjustment_reason.

These tests should be tagged with @tag('post_install', 'manual') or similar, following OCA testing conventions for modules that depend on external dependencies.

---

⚠️ PR Aging Alert: CRITICAL

This PR by @Murtaza-OSI has been waiting for 1173 days — that is over 39 months without being merged or closed.
🔴 Zero human reviews in 1173 days. This contributor invested their time to improve this module. The PSC owes them at least a response — even a "needs changes" is better than silence.
💤 No activity for 800 days. Has this PR been forgotten?

Every ignored PR is a contributor who might not come back. Review time matters. (OCA Aging Report)

---

Reciprocal Review Request

Hi everyone! I found some test failures on this PR and left detailed feedback above. I am happy to discuss or help debug. In the meantime, if any of you get a chance, I would appreciate a look at my open PR(s):

My open PRs across OCA:

• hr-attendance#262 [16.0][ADD] Hr_attendance_idsecure: iDSecure (ControliD) attendance integration
• stock-logistics-workflow#2276 [16.0][ADD] stock_move_line_devaluation
• stock-logistics-workflow#2275 [16.0][ADD] Stock move line analytic account
• stock-logistics-workflow#2268 [16.0][ADD] stock_move_line_picking_partner
• purchase-workflow#2694 [16.0][IMP]Purchase workflow added to review state & exception fix

Reviewing each other's work helps the whole community move forward. Thank you!

---

Environment via OCA Neural Reviewer: Minikube + K8s Job + oca-ci/py3.10-odoo16.0 | Odoo 16.0
Automated review by OCA Neural Reviewer + qwen3-coder:30b