Repository navigation
[16.0][IMP] pms: non-refundable option for cancellation rules - #458
Merged
OCA-git-bot merged 1 commit intoOct 17, 2026
Merged
Conversation
days_intime was labelled as the opposite of what the code does: cancelling at least that many days before check-in is free, and 0 means free until arrival. Non-refundable rates had to be emulated with a huge number of days. Add a Non-refundable flag that always applies the late penalty, and fix the label and help of days_intime.
Author
|
cc @DarioLodeiros as maintainer of this module. |
Member
|
/ocabot merge minor |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
Contributor
|
Congratulations, your PR was merged at 9f53d50. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The form labels
days_intimeas "Max. days InTime before Checkin", which is the opposite of what the code does: cancelling at least N days before check-in is free, and0means free until arrival. As a result, non-refundable rates had to be emulated with a huge number of days.is_non_refundableflag: the late penalty always applies, and the days field is hidden.days_intimenow describe the actual behaviour, withes.poupdated.Existing rules keep their behaviour. Tests are added for both cases.