Repository navigation
[16.0][FIX] pms: keep the residence country of guests without state - #459
Merged
OCA-git-bot merged 1 commit intoOct 17, 2026
Merged
Conversation
_compute_country_id cleared the residence country of any guest without
a state when the partner or the nationality changed, so most foreign
guests lost it on their first save with an identity document and could
not be checked in ("Personal data is missing for check-in").
Author
|
@DarioLodeiros could you review this one? Thanks. |
Member
|
/ocabot merge minor |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
Contributor
|
Congratulations, your PR was merged at 60fdbea. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug:
_compute_country_idclears the residence country of any guest without a state whenever the partner or the nationality changes. Most foreign guests have no state, so they lose their country on the first save with an identity document (the partner gets linked) and the check-in fails with "Personal data is missing for check-in". Introduced in the residence fields refactor (cc14d92).Fix: only assign
Falsewhen the country is already empty, like the sibling computes.Tests: new case in
test_pms_checkin_partner.