Repository navigation
[16.0][IMP] pms: agencies only pay the stay by default - #461
Open
davidpachecop wants to merge 1 commit into
Open
davidpachecop wants to merge 1 commit into
davidpachecop wants to merge 1 commit into
Conversation
Agencies invoiced always also became the payer of the extra services. By default they are now invoiced the nights and the board services and the extras are left to the guest; a new agency option keeps invoicing the extras to the agency.
Author
|
@DarioLodeiros @jesusVMayor could you review this one? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agencies invoiced "Always" became the payer of every service of their reservations, extras included (bar, minibar, special dinners...), although the usual contract only covers the stay and the guest pays the extras at the property.
pms.service._compute_default_invoice_to. It applies to new services only; existing folios are not rewritten.Behaviour change: existing agencies invoiced "Always" stop being invoiced the extras of new services unless the option is checked.
Tested with new cases in
test_pms_service.py; fullpmssuite run locally.