[19.0][FIX] report_async: invalidate ORM cache after raw SQL update - #1189
Open
samirGuesmi wants to merge 1 commit into
Open
[19.0][FIX] report_async: invalidate ORM cache after raw SQL update#1189samirGuesmi wants to merge 1 commit into
samirGuesmi wants to merge 1 commit into
Conversation
Contributor
|
Hi @kittiu, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After creating the attachment with SUPERUSER_ID, run_report updates create_uid/write_uid via a raw SQL execute().
The ORM cache is not invalidated, so when _send_email() renders the template the attachment.create_uid still holds SUPERUSER_ID (OdooBot) instead of the actual user, producing "Dear OdooBot" in the notification email.
This small fix will add attachment.invalidate_recordset(["create_uid", "write_uid"]) just after the cr.execute() block so the template reads the correct value.