feat(ui): Improve overlapping charts - #2864
Open
maggie-li-yd wants to merge 18 commits into
Open
Conversation
5 tasks
maggie-li-yd
force-pushed
the
maggie-li-yd/2487-overlapping-charts-improvements
branch
from
July 7, 2026 08:57
0b19cb2 to
4acaab8
Compare
maggie-li-yd
force-pushed
the
maggie-li-yd/2487-overlapping-charts-improvements
branch
from
July 20, 2026 01:45
4acaab8 to
6ec6cdb
Compare
maggie-li-yd
force-pushed
the
maggie-li-yd/2487-overlapping-charts-improvements
branch
from
August 31, 2026 02:12
6ec6cdb to
bca16d3
Compare
maggie-li-yd
marked this pull request as ready for review
August 31, 2026 07:08
maggie-li-yd
requested review from
LSriragavan,
brandantck,
jerome-ng,
khairul-syazwan and
p-hoffmann
as code owners
August 31, 2026 07:08
Contributor
There was a problem hiding this comment.
Pull request overview
Improves overlapping chart transitions, presentation, and warnings in the Vue MRI charting interface.
Changes:
- Adds chart-mode transition planning, confirmation, and X-axis reconciliation.
- Updates chart icons, coloring behavior, tooltips, and localization.
- Adds component tests and adjusts Vitest/Playwright configuration.
Reviewed changes
Copilot reviewed 34 out of 34 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
tests/e2e/playwright.config.ts |
Removes CI failure cap. |
plugins/ui/apps/vue-mri-ui-lib/vite.config.ts |
Aligns Vue Test Utils with the app’s Vue instance. |
plugins/ui/apps/vue-mri-ui-lib/src/utils/Constants.ts |
Updates chart tooltip key. |
plugins/ui/apps/vue-mri-ui-lib/src/utils/chartTypeChange.ts |
Plans chart-mode transitions and warnings. |
plugins/ui/apps/vue-mri-ui-lib/src/utils/__tests__/chartTypeChange.test.ts |
Tests transition planning. |
plugins/ui/apps/vue-mri-ui-lib/src/styles/chartButton.scss |
Styles SVG chart icons. |
plugins/ui/apps/vue-mri-ui-lib/src/styles/axisMenuButton.scss |
Sizes SVG axis icons. |
plugins/ui/apps/vue-mri-ui-lib/src/store/modules/chart.ts |
Reconciles X axes when leaving stacked mode. |
plugins/ui/apps/vue-mri-ui-lib/src/lib/ui/__tests__/app-segmented-button.test.ts |
Corrects selection assertions. |
plugins/ui/apps/vue-mri-ui-lib/src/lib/i18n.ts |
Adds warning text and tooltip translations. |
plugins/ui/apps/vue-mri-ui-lib/src/lib/ChartConfigService.ts |
Updates Vue chart tooltip key. |
plugins/ui/apps/vue-mri-ui-lib/src/components/StackBarChart.vue |
Removes stale per-bar coloring. |
plugins/ui/apps/vue-mri-ui-lib/src/components/icons/OverlappingHistogramIcon.vue |
Adds overlapping histogram icon. |
plugins/ui/apps/vue-mri-ui-lib/src/components/ChartTypeChangeWarningDialog.vue |
Adds chart-change confirmation dialog. |
plugins/ui/apps/vue-mri-ui-lib/src/components/ChartTypeAxisButton.vue |
Integrates transition planning and confirmation. |
plugins/ui/apps/vue-mri-ui-lib/src/components/ChartToolbar.vue |
Uses an SVG for the chart button. |
plugins/ui/apps/vue-mri-ui-lib/src/components/ChartController.vue |
Selects icons by effective chart mode. |
plugins/ui/apps/vue-mri-ui-lib/src/components/ChartButton.vue |
Supports component-based icons. |
plugins/ui/apps/vue-mri-ui-lib/src/components/AxisMenuButton.vue |
Supports component-based axis icons. |
plugins/ui/apps/vue-mri-ui-lib/src/components/__tests__/ChartTypeAxisButton.test.ts |
Tests warning workflow. |
plugins/ui/apps/vue-mri-ui-lib/src/components/__tests__/ChartToolbar.test.ts |
Tests toolbar icon selection. |
plugins/ui/apps/vue-mri-ui-lib/src/components/__tests__/ChartController.test.ts |
Tests mode-specific axis icons. |
plugins/ui/apps/vue-mri-ui-lib/src/components/__tests__/AxisMenuButton.test.ts |
Tests SVG axis rendering. |
plugins/ui/apps/mri-pa-ui/src_ui/mri/lib/charts/ChartConfigService.js |
Updates legacy chart tooltip key. |
plugins/ui/apps/mri-pa-ui/src_ui/mri/lib/BookmarkUtils.js |
Updates bookmarked chart name. |
plugins/ui/apps/mri-pa-ui/src_ui/mri/i18n/text.properties |
Updates default tooltip translation. |
plugins/ui/apps/mri-pa-ui/src_ui/mri/i18n/text_zh.properties |
Updates Chinese tooltip translation. |
plugins/ui/apps/mri-pa-ui/src_ui/mri/i18n/text_pt.properties |
Updates Portuguese tooltip translation. |
plugins/ui/apps/mri-pa-ui/src_ui/mri/i18n/text_fr.properties |
Updates French tooltip translation. |
plugins/ui/apps/mri-pa-ui/src_ui/mri/i18n/text_es.properties |
Updates Spanish tooltip translation. |
plugins/ui/apps/mri-pa-ui/src_ui/mri/i18n/text_en_US_saptrc.properties |
Updates translation trace text. |
plugins/ui/apps/mri-pa-ui/src_ui/mri/i18n/text_en_US_sappsd.properties |
Updates pseudo-localized tooltip. |
plugins/ui/apps/mri-pa-ui/src_ui/mri/i18n/text_en_GB.properties |
Updates British English tooltip. |
plugins/ui/apps/mri-pa-ui/src_ui/mri/i18n/text_de.properties |
Updates German tooltip translation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
khairul-syazwan
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update UI/UX related to overlapping charts in cohort builder
Demo
2487-demo.mov
Merge Checklist
Please cross check this list if additions / modifications needs to be done on top of your core changes and tick them off. Reviewer can as well glance through and help the developer if something is missed out.
developbranch)