Conversation
The repository has a test suite and no check running it, so a pull request could merge with it failing.
This was referenced Aug 22, 2026
Contributor
Author
|
Superseded by #128, which back-merges the same workflows from main with the tightened guard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two guards. The repository had neither.
The tests
There was a test suite and nothing running it, so a pull request could merge with it failing.
update-exchange-rates.ymlwas the only workflow.Adds a
testsworkflow —npm cithennpm test, Node 20, matching the exchange-rates job — on every pull request and on pushes tomainanddevelop.npm cirather thannpm install, so a run tests the versionspackage-lock.jsonpins rather than whatever resolves on the day.The source of a merge into main
mainis what production serves, and it should be reached one of two ways: a release cut fromdevelop, or a hotfix. Its history says otherwise —FixEditorForStandardForm,ClickableLinksandchore/dependabot-transitive-bumpsall merged straight in.GitHub has no setting for "only these branches may open a pull request into this one", so a check stands in for it:
guard mainfails when the source branch is neitherrelease/*norhotfix/*, with an error saying where the work belongs instead.Nothing automated is affected —
update-exchange-rates.ymlpushes todata/exchange-rates, not tomain.Neither workflow is path-filtered
Deliberately. A required check that only runs sometimes cannot be satisfied the rest of the time: nothing reports, and the pull request waits for a status that never arrives.
After this merges
node --testandsource branchbecome required checks on the branches they apply to. Until then they report and nothing depends on them.