#14274 Fix invalid index range in dataChanged() from table row editor#14342
Open
kriben wants to merge 1 commit into
Open
#14274 Fix invalid index range in dataChanged() from table row editor#14342kriben wants to merge 1 commit into
kriben wants to merge 1 commit into
Conversation
Valid Qt column indices are 0..columnCount()-1, but the bottom-right model index was constructed with column columnCount(). Since QAbstractItemModel::index() validates its arguments, this produced an invalid QModelIndex(-1,-1) passed to dataChanged(), causing a console warning on every table row update, e.g. when adding or moving 3D well path pick targets. Fix the same off-by-one in modelIndexFromPdmObject(). Fixes #14274.
kriben
marked this pull request as ready for review
July 14, 2026 09:23
Collaborator
Author
|
@jonjenssen I was not able to reproduce it on my machine, but I think this should fix it. Can you test when back from holiday? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Valid Qt column indices are 0..columnCount()-1, but the bottom-right model index was constructed with column columnCount(). Since QAbstractItemModel::index() validates its arguments, this produced an invalid QModelIndex(-1,-1) passed to dataChanged(), causing a console warning on every table row update, e.g. when adding or moving 3D well path pick targets. Fix the same off-by-one in modelIndexFromPdmObject().
Fixes #14274.