enable configuration file for material properties#97
Draft
gknapp1 wants to merge 5 commits into
Draft
Conversation
…files - pull request CI enforces that the material files haven't been manually changed - weekly chron job checks the main branch of the Myna repo for any changes, updates if so
- thermoPath is now a FoamDict, allowing it to use the #include syntax - transportProperties also now uses the #include syntax - function objects now set isoValues to default to thermoPath values, if not directly set by the user - some updates to the build files due to functionObjects now depending on the readThermoPath utility - Allrun provides setting the path to the AdditiveFOAM repo to find the materials config file folder
- not really needed, but the intent is clearer
Collaborator
|
Is there a minimum working example here where we just provide material configuration files, similar to what we provide for the nlight laser profiles, here: |
Collaborator
Author
@colemanjs Yes, I updated the AMB2018-02-B tutorial to use the material configuration file instead of directly specifying the thermoPath and transportProperties. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements two main features:
thermoPathfile format and associated reader to allow for users to user the OpenFOAM file#includesyntax to set values from the database.thermoPathtable for settingisoValues. If the user manually specifiesisoValue/isoValuesin controlDict, then those will be used as-is.Since this feature needs some changes to the solver to support this approach to material configuration, this feature is in draft state until the following structural decisions & changes are implemented through other PRs:
$solidus) or through default settings read from thermoPath and set in the solver?This feature will also be in draft state until the following features are added, based on the decisions above:
0/T, Marangoni coefficient in0/U)