Skip to content

feat: Implement PUT endpoint and UI for question editing - #370

Merged
LaserBread merged 2 commits into
developmentfrom
feature/question-editing-fix
Jun 4, 2026
Merged

LaserBread merged 2 commits into
developmentfrom
feature/question-editing-fix

Conversation

@thaivinhle

@thaivinhle thaivinhle commented Nov 20, 2025 •

Copy link
Copy Markdown
Contributor

Description

Summary of work:

  • Implemented the PUT /courses/:course_id/questions/:question_id API endpoint in core/.
  • Implemented the updateQuestion function and dispatched the updateQuestionInLecture Redux action in SingleQuestionTeacher.jsx.
  • Fixed the build failure by defining the updateQuestionInLecture Redux action.
  • Resolved navigation bug in QuestionCard.jsx to allow access to the edit form.

Fixes #366

Checklist:

Before you submit your Pull Request, please make sure you have completed the following tasks:

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.
  • I have tagged my PR with the appropriate label(s).

@thaivinhle
thaivinhle requested review from a team as code owners November 20, 2025 21:26
@MigrainePanda MigrainePanda added the development Updates and modifications to development/deployment tools label Nov 20, 2025
Comment thread client/src/components/QuestionCard.jsx

@LaserBread LaserBread left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the code looks very good. However, would you mind adding some test cases for your core/app/api/questions.js? I can totally help if you need it.

Also check my comment in the commit

@github-project-automation github-project-automation Bot moved this from Backlog to In Progress in classroom-polling Nov 23, 2025

@LaserBread LaserBread left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for handoff

@LaserBread
LaserBread enabled auto-merge May 25, 2026 05:48

@GHop95 GHop95 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed, looks good.

@GHop95

GHop95 commented May 25, 2026

Copy link
Copy Markdown

Reviews, looks good.

@GHop95 GHop95 closed this May 25, 2026
auto-merge was automatically disabled May 25, 2026 06:01

Pull request was closed

@github-project-automation github-project-automation Bot moved this from In Progress to Done in classroom-polling May 25, 2026
@GHop95 GHop95 reopened this May 25, 2026
@github-project-automation github-project-automation Bot moved this from Done to In Progress in classroom-polling May 25, 2026
@LaserBread
LaserBread added this pull request to the merge queue Jun 4, 2026
Merged via the queue into development with commit 78b949c Jun 4, 2026
15 checks passed
@LaserBread
LaserBread deleted the feature/question-editing-fix branch June 4, 2026 22:19
@github-project-automation github-project-automation Bot moved this from In Progress to Done in classroom-polling Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development Updates and modifications to development/deployment tools

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Leftover TODO: Update to props in the SingleQuestionTeacher component

4 participants