Add Discord webhook notifications for plugin downloads (#157) by Zoriot · Pull Request #196 · OakLoaf/PluginUpdater

Zoriot · 2026-08-18T13:17:55Z

Implement basic Discord webhook support to send notifications when plugins are successfully downloaded. Uses jdwebhooks 2.0.0 library with Discord's Components V2 API.

Changes:

Add jdwebhooks 2.0.0 dependency to common/impl
Create DiscordWebhookNotifier class for sending webhook notifications
Add discord-webhook configuration section to config.yml (disabled by default)
Update ConfigManager to load and reload webhook settings
Integrate webhook notifications in UpdateHandler on successful downloads
Update UpdaterImpl to initialize and manage webhook notifier lifecycle

Webhook notifications include:

Plugin name
Version change (old → new)
Update type (MAJOR, MINOR, PATCH, etc.)
Changelog link (if available)

Infos

Users can enable by setting discord-webhook.enabled to true and providing a webhook-url in config.yml.

Closes #157

Config currently does not update automatically
This implementation set both Avatar + Users - we could also not set that and use it from the Webhook.
Currently it was only implemented for Updates, Update available might be a feature i contribute

AI Disclosure

GitHub Copilot was used for most of the implementation, all code was manually verified & tested on paper. Additional Changes was made to ensure it works correctly.

Implement basic Discord webhook support to send notifications when plugins are successfully downloaded. Uses jdwebhooks 2.0.0 library with Discord's Components V2 API. Changes: - Add jdwebhooks 2.0.0 dependency to common/impl - Create DiscordWebhookNotifier class for sending webhook notifications - Add discord-webhook configuration section to config.yml (disabled by default) - Update ConfigManager to load and reload webhook settings - Integrate webhook notifications in UpdateHandler on successful downloads - Update UpdaterImpl to initialize and manage webhook notifier lifecycle Webhook notifications include: - Plugin name - Version change (old → new) - Update type (MAJOR, MINOR, PATCH, etc.) - Changelog link (if available) Users can enable by setting discord-webhook.enabled to true and providing a webhook-url in config.yml. Closes OakLoaf#157 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Zoriot · 2026-09-12T08:47:02Z

@OakLoaf may you do a Review for this one?

OakLoaf · 2026-09-12T20:21:21Z

I'm afraid I'm a bit limited on time at the moment, but will try and make some time in the coming weeks to work on, review and merge for v5

OakLoaf

Thank you very much for this PR, the majority of this looks really good and ready to go, mainly just some nitpick changes.

I've been inspired by this PR to create a notifier system, so this PR will first be merged into the 'notifier' branch which will be later merged into 'v5' following those changes. The main changes from a user perspective will be the configuration but it should allow the ability to create notifications for other platforms in the future.
That doesn't change the direction or scope of this PR, so don't worry about implementing/changing anything other than the things mentioned in the review :)

OakLoaf · 2026-09-15T21:15:59Z

+        Config discordConfig = config.get("discord-webhook");
+        if (discordConfig != null) {
+            this.discordWebhookEnabled = discordConfig.getOrElse("enabled", false);
+            this.discordWebhookUrl = discordConfig.getOrElse("webhook-url", "");
+        } else {
+            this.discordWebhookEnabled = false;
+            this.discordWebhookUrl = "";
+        }
+


I think it would be cleaner to merge discordWebhookEnabled into discordWebhookUrl where the url is null or an empty string if disabled. I don't mind keeping the separate options in the config for convenience and clarity.

OakLoaf · 2026-09-15T21:18:29Z

+        try {
+            Version currentVersion = pluginData.currentVersion();
+            Optional<Version> latestVersionOpt = pluginData.latestVersion();
+


Suggested change

OakLoaf · 2026-09-15T21:18:47Z

+
+        try {
+            Version currentVersion = pluginData.currentVersion();
+            Optional<Version> latestVersionOpt = pluginData.latestVersion();


To match the rest of the project it should be named latestVersionOptional, or alternatively use the following and do a null check:

Suggested change

Optional<Version> latestVersionOpt = pluginData.latestVersion();

Version latestVersion = pluginData.latestVersion().orElse(null);

OakLoaf · 2026-09-15T21:22:35Z

+            List<ContainerableComponent> components = new ArrayList<>();
+
+            components.add(Component.textDisplay("**" + pluginName + " Updated**"));
+
+            components.add(Component.textDisplay("**Version:** " + versionString));


We don't need new lines between these lines

Suggested change

List<ContainerableComponent> components = new ArrayList<>();

components.add(Component.textDisplay("**" + pluginName + " Updated**"));

components.add(Component.textDisplay("**Version:** " + versionString));

List<ContainerableComponent> components = new ArrayList<>();

components.add(Component.textDisplay("**" + pluginName + " Updated**"));

components.add(Component.textDisplay("**Version:** " + versionString));

OakLoaf · 2026-09-15T21:29:00Z

+                            () -> "Discord webhook returned unsuccessful response. Status code: "
+                                + statusCode
+                                + ", response: "
+                                + response


Could we replace this string formatting with similar to the rest of the project like below, we can then inline this log

Suggested change

() -> "Discord webhook returned unsuccessful response. Status code: "

+ statusCode

+ ", response: "

+ response

() -> "Discord webhook returned unsuccessful response. Status code: %s, response: %s"

.formatted(statusCode, response)

OakLoaf · 2026-09-15T21:41:29Z

+            String versionDiff = pluginData.versionDifference().name();
+            if (!versionDiff.equals("UNKNOWN")) {
+                components.add(Component.textDisplay("**Update Type:** " + versionDiff));
+            }


Suggested change

String versionDiff = pluginData.versionDifference().name();

if (!versionDiff.equals("UNKNOWN")) {

components.add(Component.textDisplay("**Update Type:** " + versionDiff));

}

VersionDifference versionDiff = pluginData.versionDifference();

if (versionDiff != VersionDifference.UNKNOWN)) {

components.add(Component.textDisplay("**Update Type:** " + versionDiff.name()));

}

OakLoaf · 2026-09-15T21:44:24Z

        return config;
    }

+    public DiscordWebhookNotifier discordWebhookNotifier() {


Can we change this to discordWebHookNotifier please.
Additionally, for this method can we return Optional<DiscordWebhookNotifier> and then in places we want to use the notifier we can run #discordWebHookNotifier#ifPresent

OakLoaf · 2026-09-15T21:45:24Z

+        }
+    }
+
+    public void close() {


Could we rename this to shutdown to be named similarly to other similar methods in this project

OakLoaf · 2026-09-15T21:46:50Z


    api("io.github.revxrsal:lamp.common:4.0.0-rc.18")
    api("com.electronwill.night-config:yaml:3.9.0")
+    api("io.github.4drian3d:jdwebhooks:2.0.0")


I don't think we'll need this one outside of this module for the time being so can we set the scope of this to implementation please?

OakLoaf · 2026-09-15T21:47:09Z

    private final List<PluginDataCollector.Factory> collectors;
    private final UpdateHandler<T> updateHandler;
    private final ConfigManager config;
+    private DiscordWebhookNotifier discordWebhookNotifier;


Suggested change

private DiscordWebhookNotifier discordWebhookNotifier;

private DiscordWebhookNotifier discordWebHookNotifier;

OakLoaf added this to the v5 milestone Sep 15, 2026

OakLoaf mentioned this pull request Sep 15, 2026

v5 #210

Draft

6 tasks

OakLoaf requested changes Sep 15, 2026

View reviewed changes

OakLoaf changed the base branch from main to notifier September 15, 2026 21:57

Navigation Menu

Add Discord webhook notifications for plugin downloads (#157) - #196

Add Discord webhook notifications for plugin downloads (#157)#196
Zoriot wants to merge 1 commit into
OakLoaf:notifierfrom
Zoriot:webhook

Zoriot commented Aug 18, 2026

Uh oh!

Zoriot commented Sep 12, 2026

Uh oh!

OakLoaf commented Sep 12, 2026

Uh oh!

OakLoaf left a comment

Uh oh!

OakLoaf Sep 15, 2026

Uh oh!

OakLoaf Sep 15, 2026

Uh oh!

OakLoaf Sep 15, 2026

Uh oh!

OakLoaf Sep 15, 2026

Uh oh!

OakLoaf Sep 15, 2026

Uh oh!

OakLoaf Sep 15, 2026

Uh oh!

OakLoaf Sep 15, 2026

Uh oh!

OakLoaf Sep 15, 2026

Uh oh!

OakLoaf Sep 15, 2026

Uh oh!

OakLoaf Sep 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	Optional<Version> latestVersionOpt = pluginData.latestVersion();
	Version latestVersion = pluginData.latestVersion().orElse(null);

	private DiscordWebhookNotifier discordWebhookNotifier;
	private DiscordWebhookNotifier discordWebHookNotifier;

Conversation

Zoriot commented Aug 18, 2026

Changes:

Webhook notifications include:

Infos

AI Disclosure

Uh oh!

Zoriot commented Sep 12, 2026

Uh oh!

OakLoaf commented Sep 12, 2026

Uh oh!

OakLoaf left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants