fix(updates): reuse Android APK after installer dismissal - #401
fix(updates): reuse Android APK after installer dismissal#401veryCrunchy wants to merge 4 commits into
Conversation
Obiente previewNC Native · Obiente updates this comment as the preview changes. |
veryCrunchy
added
priority:P1
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6779f096cb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Button( | ||
| onClick = { requestInstall(release) }, | ||
| enabled = !installing, | ||
| ) { | ||
| Text("Open installer again") |
There was a problem hiding this comment.
On direct-package desktop builds, ConfirmationOpened also reaches this shared branch, but clicking this button calls requestInstall, then DesktopAppUpdater.beginUpdate, which cleans the staged package and starts downloading again from zero. The desktop UI therefore promises APK reuse that only Android implements; make this wording/action Android-specific or add equivalent desktop package reuse.
AGENTS.md reference: AGENTS.md:L78-L85
Useful? React with 👍 / 👎.
1 participant
Summary
Context
Follow-up to #176.
Closing Android's system installer currently leaves the update card in
ConfirmationOpened. A retry also deletes the staged APK because cleanup protects only the partial download, forcing a complete download before Android can show the same prompt again.Validation
On the dedicated build host at commit
6779f096cbbf676186d5ae402a15132bca4af4f1:bash tools/check-repository.shbash tools/test-prerelease-update-contract.sh:ui:desktopTest:androidApp:testDebugUnitTest:androidApp:verifyReleaseLintGate:androidApp:assembleDebugResult:
BUILD SUCCESSFULwith 147 actionable tasks.