Skip to content

feat: Add slack fields to subscriptions#425

Merged
grace-rehn merged 1 commit into
mainfrom
grace/slack-subscriptions
Jul 9, 2026
Merged

feat: Add slack fields to subscriptions#425
grace-rehn merged 1 commit into
mainfrom
grace/slack-subscriptions

Conversation

@grace-rehn

@grace-rehn grace-rehn commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Adds support for slack subscriptions

  • Added SlackChannelIds, SlackChannelNames, SlackFrequencyPeriod and SlackDigestFormat to EventNotificationSubscription
  • Set defaults for these fields in NewSubscription()
  • Added tests covering the new defaults and JSON round-trip

Fixes HPY-1358

@grace-rehn
grace-rehn requested a review from a team July 9, 2026 03:14

@HuyPhanNguyen HuyPhanNguyen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hnrkndrssn hnrkndrssn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@grace-rehn
grace-rehn merged commit e117fff into main Jul 9, 2026
6 of 8 checks passed
@grace-rehn
grace-rehn deleted the grace/slack-subscriptions branch July 9, 2026 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants