Skip to content

chore: set up Java 17 in the publish release workflow - #2821

Merged
fadi-george merged 1 commit into
mainfrom
fadi/publish-release-java-17
Oct 28, 2026
Merged

fadi-george merged 1 commit into
mainfrom
fadi/publish-release-java-17

Conversation

@fadi-george

Copy link
Copy Markdown
Contributor

Description

One Line Summary

Use actions/setup-java with Java 17 in the Publish Release workflow, matching the other workflows.

Details

Motivation

Publish Release failed in run 40624882153 with Android Gradle plugin requires Java 17 to run. You are currently using Java 11.

The runner image now defaults to Java 25. The old "Ensure Java 11 or 17" step treated anything other than 11 or 17 as a reason to install OpenJDK 11, and AGP rejects Java 11. In September the runner defaulted to 17, so that step did nothing.

Scope

Only the Java setup step in publish-release.yml changes. It now uses the same setup-java@v5 / Temurin 17 config as .github/actions/project-setup. The build, signing, and publish steps are unchanged.

Testing

Manual testing

Not run yet. The workflow only runs on workflow_dispatch and publishes, so it gets verified on the next release run.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@fadi-george
fadi-george requested a review from a team as a code owner October 28, 2026 03:25
@github-actions

Copy link
Copy Markdown
Contributor

📊 Diff Coverage Report

✓ Coverage check passed (no source files changed)

📥 View workflow run

@abdulraqeeb33 abdulraqeeb33 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failed publish run matches the description. The runner was on Java 25.0.4.1, the old step installed OpenJDK 11, and AGP 8.8.2 stopped with "requires Java 17".

The new step is the same actions/setup-java@v5 / Temurin 17 config as project-setup and setup-demo. It runs before every ./gradlew call in the job. This PR's CI is green on that same JDK. The publish workflow itself stays workflow_dispatch, so the next release run is the first time this file executes.

@abdulraqeeb33

Copy link
Copy Markdown
Contributor

This does not change what customers compile against or what runs on their devices.

Customers consume the published AAR. Their build does not recompile the SDK sources, so their JDK does not have to match the JDK used in this workflow. Class files stay Java 8 bytecode (sourceCompatibility and jvmTarget are 1.8), and min SDK stays 21.

CI was already running on JDK 17. This makes the publish job use that same JDK. AGP 8.8.2 needs JDK 17 to perform the build. That requirement is for the machine building the SDK.

@fadi-george
fadi-george merged commit 96c5d30 into main Oct 28, 2026
6 checks passed
@fadi-george
fadi-george deleted the fadi/publish-release-java-17 branch October 28, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants