Repository navigation
chore: [SDK-5500] move demo to Capacitor 8 scene template - #72
Merged
Merged
Conversation
nan-li
approved these changes
Oct 13, 2026
nan-li
left a comment
Contributor
There was a problem hiding this comment.
Not blocking, but SceneDelegateProxy only exists from Capacitor 8.5.0 on, and the demo still allows ^8.3.0. Older demo installs keep their locked version through vp install. I hit this locally in a demo app run since I had 8.3.2 still installed, and vp run ios fails here with cannot find 'SceneDelegateProxy' in scope.
Might be worth bumping @capacitor/core, @capacitor/ios, @capacitor/android and @capacitor/cli to ^8.5.0 in examples/demo/package.json, and committing the regenerated Package.swift too.
Base automatically changed from
fadi/SDK-5461-cold-start-tap-launch-url-scene-based
to
main
October 13, 2026 17:09
Match what `cap add ios` generates for Capacitor 8 apps: SceneDelegate creates the CAPBridgeViewController, and AppDelegate hands out the scene configuration. Keep handleApplicationNotifications: false (documented setup) and note why. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fadi-george
force-pushed
the
fadi/sdk-5500
branch
from
October 13, 2026 17:09
27e4bf9 to
f016909
Compare
Contributor
Author
|
Bumped Capacitor to ^8.5.0 and committed the regenerated Package.swift |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Move the iOS demo app to the Capacitor 8 scene template, so it matches what
cap add iosgenerates for new apps.Details
Motivation
The demo still used the older no-scene AppDelegate with a storyboard. Capacitor 8 apps create
CAPBridgeViewControllerinSceneDelegate, after launch, which changes when the bridge and its notification routing come up. Running the demo and the E2E suite against the current template keeps them representative of customer apps. This is part of SDK-5499 (cold-start tap coverage); the shared E2E test is SDK-5501.Stacked on #71.
Scope
SceneDelegate.swift(new, copied from Capacitor 8.5.2ios-spm-template) and registered in the Xcode project.AppDelegate.swiftreplaced with the template version: it returns the scene configuration, and URL / user-activity handling moves toSceneDelegateProxyinSceneDelegate.Info.plistgetsUIApplicationSceneManifest, matching the template.handleApplicationNotifications: falsestays, since it is the documented OneSignal setup. Added a comment explaining that without it Capacitor'sNotificationRouterbecomes the notification delegate and suppresses foreground display.demo_podsanddemo_cap7are unchanged.Testing
Unit testing
Not applicable (demo app config only).
Manual testing
iOS 26.2 simulator, Capacitor 8.5.3, SPM demo:
SceneDelegateis the active scene delegate.simctl pushwith launch URL, tap banner): click fires and the launch URL opens (with fix: [SDK-5461] cold-start tap capture on scene apps and launch URL replay #71).vp checkpasses oncapacitor.config.ts.Affected code checklist
Checklist
Overview
Testing
Final pass
🤖 Generated with Claude Code