Repository navigation
chore: [SDK-5530] add sticky log view to demo app - #211
Merged
Merged
Conversation
sherwinski
approved these changes
Oct 22, 2026
There was a problem hiding this comment.
Multi-model review
Reviewed with Claude Opus 5.5, GPT 5.6 Sol, and Grok 4.7. Demo-only sticky log view; no SDK changes.
Act on: none blocking.
Consider
LogViewsubscribes to staticLogService.Entries.CollectionChangedand never unsubscribes (3/3).MainPageis transient andCreateWindowbuilds a new one, so an Android activity recreate can keep the old visual tree alive and re-render into detached views. Subscribe/unsubscribe on Loaded/Unloaded.Infois console-only; onlyShow/Errorpopulate the panel (3/3). Login/tag/send-notification and live-activity failure lines therefore never appear inlog_entry_*. Fine if this matches the sibling demos — testers debugging those failures without a debugger will still need logcat.
Noted
- Full rebuild on every collection change; at the 100-entry cap each new line rebuilds twice (Opus+Grok).
ScrollToEndis async insideDispatcher.Dispatch(async void) and only runs fromSizeChanged, so a same-height rebuild at the cap may not scroll (Grok).Debug.WriteLine→Console.WriteLineships emails/SMS/external IDs in Release (Opus).log_entry_{i}is 0-based oldest; the 100px viewport hides older rows from Appium unless it scrolls (same as the iOS/Android demos).
Dismissed
- Logging ActionId/Url on click events — not a regression; the old console lines omitted them too.
- Off-thread mutation of public
Entries—LogServicewriters already marshal to the main thread.
Sent by Cursor Automation: PR Reviews
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fadi-george
force-pushed
the
fadi/sdk-5530
branch
from
October 22, 2026 23:10
9c18c11 to
4bb8ce5
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
One Line Summary
Add a sticky, logcat-style Log View to the MAUI demo app.
Details
Motivation
Matches the shared demo spec (
sdk-shared/demo/build.mdPrompts 1.5, 2.0, 6.2 andstyles.mdLog View) so the shared Appium suite can assert SDK listener events (e.g. spec 13 notification click) on .NET, same as the Capacitor and React Native demos.Scope
LogService(Infoconsole only,Show/Errorconsole + view). In memory only, max 100 entries, so every launch starts empty.LogViewcontrol pinned under the app bar, abovemain_scroll_view. AutomationIds:log_view,log_entry_{index},log_clear_button,log_toggle_button.→/…,nullfor missing ids, lowercase bools.Debug.WriteLinecalls moved toLogService.Info.Testing
Manual testing
Ran the shared Appium suite (
run-all.sh --sdks=dotnet) against this branch:Notification clicklog assertions actually run (not skipped) on both platforms, including cold start, by temporarily making the missing-log-view branch throw.Affected code checklist
Checklist
Overview
Testing
Final pass
🤖 Generated with Claude Code