Repository navigation
chore: upgrade to Vite+ 1.3.0 and TypeScript 7 - #1532
Merged
Merged
Conversation
fadi-george
reviewed
Oct 13, 2026
abdulraqeeb33
approved these changes
Oct 21, 2026
abdulraqeeb33
left a comment
Contributor
There was a problem hiding this comment.
The pins match. vite-plus and the Vite core alias are 1.1.0, and Vitest and coverage-v8 are both 5.0.3. There is no direct vitest dependency. The source diffs are formatting, and the private-method spies typecheck on Vitest 5 without the old directives. CI is green.
fadi-george
requested changes
Oct 21, 2026
fadi-george
left a comment
Contributor
There was a problem hiding this comment.
Ill do some cleanup on your branch.
- Bump vite-plus and vite-plus-core to 1.3.0, @vitest/coverage-v8 to 5.0.5 - Bump typescript to 7.0.2 - Declare bun 1.4.3 via devEngines.packageManager - Use floating setup-vp@v1 in workflows Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fadi-george
approved these changes
Oct 21, 2026
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
1 Line Summary
Upgrade Vite+ to 1.3.0 and TypeScript to 7, and declare bun through
devEngines.Details
vite-plusgoes from0.2.1to1.3.0, and thevitealias and override (@voidzero-dev/vite-plus-core) go to1.3.0. Vite+ now provides the Vitest runner.@vitest/coverage-v8is now5.0.5, to match the vitest version bundled with Vite+ 1.3.0. Vite+ fails at startup if the versions differ.typescriptgoes from^6.0.3to^7.0.2. Type checking already runs through tsgolint, so this mostly affects editors.packageManager: bun@1.3.13is replaced withdevEngines.packageManagerset to bun1.4.3andonFail: download, in both the root andpreview/package.json.voidzero-dev/setup-vp@v1tag..vitest/is now ignored.@ts-expect-errordirectives on private method spies are removed because they are no longer needed.Test behavior, coverage thresholds, and the three IIFE bundle outputs are unchanged.
Systems Affected
Validation
Tests
Info
vp run build:prodpasses, including size limits and bundle validation.vp run lint:fixgives 0 errors. The 7no-floating-promiseswarnings in tests existed before this change.vp run testpasses all 558 tests in 62 files, with coverage.tsc --noEmitpasses on TypeScript 7.0.2.Checklist
Programming Checklist
Interfaces:
Functions:
Typescript:
Other:
elem of arraysyntax. PreferforEachor usemapcontextif possible. Instead, we can pass it to function/constructor so that we don't callOneSignal.contextScreenshots
Info
This is a tooling-only change with no UI changes.
Checklist
Related Tickets
🤖 Generated with Claude Code