Skip to content

chore: upgrade to Vite+ 1.3.0 and TypeScript 7 - #1532

Merged
fadi-george merged 3 commits into
OneSignal:mainfrom
fengmk2:codex/upgrade-vite-plus-1.1
Oct 21, 2026
Merged

fadi-george merged 3 commits into
OneSignal:mainfrom
fengmk2:codex/upgrade-vite-plus-1.1

Conversation

@fengmk2

@fengmk2 fengmk2 commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Description

1 Line Summary

Upgrade Vite+ to 1.3.0 and TypeScript to 7, and declare bun through devEngines.

Details

  • vite-plus goes from 0.2.1 to 1.3.0, and the vite alias and override (@voidzero-dev/vite-plus-core) go to 1.3.0. Vite+ now provides the Vitest runner.
  • @vitest/coverage-v8 is now 5.0.5, to match the vitest version bundled with Vite+ 1.3.0. Vite+ fails at startup if the versions differ.
  • typescript goes from ^6.0.3 to ^7.0.2. Type checking already runs through tsgolint, so this mostly affects editors.
  • packageManager: bun@1.3.13 is replaced with devEngines.packageManager set to bun 1.4.3 and onFail: download, in both the root and preview/ package.json.
  • The CI workflows use the floating voidzero-dev/setup-vp@v1 tag.
  • The newer oxfmt reformats a few typed arrow callbacks.
  • .vitest/ is now ignored.
  • Two @ts-expect-error directives on private method spies are removed because they are no longer needed.

Test behavior, coverage thresholds, and the three IIFE bundle outputs are unchanged.

Systems Affected

  • WebSDK
  • Backend
  • Dashboard

Validation

Tests

Info

  • vp run build:prod passes, including size limits and bundle validation.
  • vp run lint:fix gives 0 errors. The 7 no-floating-promises warnings in tests existed before this change.
  • vp run test passes all 558 tests in 62 files, with coverage.
  • tsc --noEmit passes on TypeScript 7.0.2.

Checklist

  • All the automated tests pass or I explained why that is not possible
  • I have personally tested this on my machine or explained why that is not possible
  • I have included test coverage for these changes or explained why they are not needed

Programming Checklist
Interfaces:

  • Don't use default export
  • New interfaces are in model files

Functions:

  • Don't use default export
  • All function signatures have return types
  • Helpers should not access any data but rather be given the data to operate on.

Typescript:

  • No Typescript warnings
  • Avoid silencing null/undefined warnings with the exclamation point

Other:

  • Iteration: refrain from using elem of array syntax. Prefer forEach or use map
  • Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context

Screenshots

Info

This is a tooling-only change with no UI changes.

Checklist

  • I have included screenshots/recordings of the intended results or explained why they are not needed

Related Tickets


🤖 Generated with Claude Code

Comment thread package.json Outdated

@abdulraqeeb33 abdulraqeeb33 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pins match. vite-plus and the Vite core alias are 1.1.0, and Vitest and coverage-v8 are both 5.0.3. There is no direct vitest dependency. The source diffs are formatting, and the private-method spies typecheck on Vitest 5 without the old directives. CI is green.

@fadi-george fadi-george left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ill do some cleanup on your branch.

- Bump vite-plus and vite-plus-core to 1.3.0, @vitest/coverage-v8 to 5.0.5
- Bump typescript to 7.0.2
- Declare bun 1.4.3 via devEngines.packageManager
- Use floating setup-vp@v1 in workflows

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@fadi-george fadi-george changed the title chore: upgrade to Vite+ 1.1.0 chore: upgrade to Vite+ 1.3.0 and TypeScript 7 Oct 21, 2026
@fadi-george
fadi-george merged commit 4d6ecb6 into OneSignal:main Oct 21, 2026
3 checks passed
@fengmk2
fengmk2 deleted the codex/upgrade-vite-plus-1.1 branch October 22, 2026 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants