Repository navigation
feat: [SDK-5383] enqueue a session create when a new session starts #1770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+1,639
−506
Closed
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
07b7861
feat: [SDK-5379] persistent queue and retry for sessions API requests
fadi-george 35ee971
fix: [SDK-5379] address session queue review feedback
fadi-george 0b62602
test: [SDK-5379] split session queue tests to satisfy SwiftLint body …
fadi-george 65000d0
fix: [SDK-5379] address second session queue review
fadi-george 29e1a4e
refactor: [SDK-5379] send session requests through the operation repo
fadi-george 4272695
fix: [SDK-5379] exempt session requests from Identity Verification
fadi-george 61ca74c
feat: [SDK-5379] retry failed operations on foreground and network re…
fadi-george eca3dd6
fix: [SDK-5379] drop session creates for users that will never be cre…
fadi-george 5132a8f
feat: [SDK-5383] enqueue a session create when a new session starts
fadi-george File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
96 changes: 96 additions & 0 deletions
96
iOS_SDK/OneSignalSDK/OneSignalOSCore/Source/OSOperationRetryTrigger.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| /* | ||
| Modified MIT License | ||
|
|
||
| Copyright 2026 OneSignal | ||
|
|
||
| Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| of this software and associated documentation files (the "Software"), to deal | ||
| in the Software without restriction, including without limitation the rights | ||
| to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| copies of the Software, and to permit persons to whom the Software is | ||
| furnished to do so, subject to the following conditions: | ||
|
|
||
| 1. The above copyright notice and this permission notice shall be included in | ||
| all copies or substantial portions of the Software. | ||
|
|
||
| 2. All copies of substantial portions of the Software may only be used in connection | ||
| with services provided by OneSignal. | ||
|
|
||
| THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| THE SOFTWARE. | ||
| */ | ||
| import Foundation | ||
| import Network | ||
|
|
||
| protocol OSNetworkPathMonitoring: AnyObject { | ||
| /// Calls `onAvailable` each time the network becomes available after being unavailable. | ||
| func start(onAvailable: @escaping () -> Void) | ||
| } | ||
|
|
||
| final class OSNetworkPathMonitor: OSNetworkPathMonitoring { | ||
| private let monitor = NWPathMonitor() | ||
|
|
||
| func start(onAvailable: @escaping () -> Void) { | ||
| var wasSatisfied: Bool? | ||
| monitor.pathUpdateHandler = { path in | ||
| let isSatisfied = path.status == .satisfied | ||
| defer { wasSatisfied = isSatisfied } | ||
| if isSatisfied, wasSatisfied == false { | ||
| onAvailable() | ||
| } | ||
| } | ||
| monitor.start(queue: DispatchQueue(label: "OneSignal.OSNetworkPathMonitor")) | ||
| } | ||
|
|
||
| deinit { | ||
| monitor.cancel() | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| Wakes failed operations early: calls `onRetry` when the app comes to the foreground, and when a | ||
| network becomes available while it is in the foreground. Network changes in the background are | ||
| ignored, since a suspended app could not finish the attempt. | ||
| */ | ||
| public final class OSOperationRetryTrigger { | ||
| private let pathMonitor: OSNetworkPathMonitoring | ||
| /// Set once by the owner, before the trigger is handed out. | ||
| var onRetry: () -> Void = {} | ||
| private let lock = NSLock() | ||
| private var isForeground = false | ||
| private var isMonitoring = false | ||
|
|
||
| init(pathMonitor: OSNetworkPathMonitoring = OSNetworkPathMonitor()) { | ||
| self.pathMonitor = pathMonitor | ||
| } | ||
|
|
||
| public func onFocus() { | ||
| let shouldStartMonitoring = lock.withLock { | ||
| isForeground = true | ||
| defer { isMonitoring = true } | ||
| return !isMonitoring | ||
| } | ||
| if shouldStartMonitoring { | ||
| pathMonitor.start { [weak self] in | ||
| self?.onNetworkAvailable() | ||
| } | ||
| } | ||
| onRetry() | ||
| } | ||
|
|
||
| public func onUnfocus() { | ||
| lock.withLock { isForeground = false } | ||
| } | ||
|
|
||
| private func onNetworkAvailable() { | ||
| guard lock.withLock({ isForeground }) else { | ||
| return | ||
| } | ||
| onRetry() | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
directAttributionIdis always nil. Fine for this PR. Android #2783 attaches a notification open, and there is no iOS PR for that yet.